Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesnt manage nested dirs correctly #6

Open
AlexandreBonaventure opened this issue Sep 6, 2017 · 1 comment
Open

Doesnt manage nested dirs correctly #6

AlexandreBonaventure opened this issue Sep 6, 2017 · 1 comment

Comments

@AlexandreBonaventure
Copy link

AlexandreBonaventure commented Sep 6, 2017

Hello,
I've noticed html isn't copied in the right place when using nested directories in output path.
Here's a fork showing the bug (you'll have to run your example): https://github.com/AlexandreBonaventure/rollup-plugin-fill-html

You'll see that:
index.html -> /bug/dist/index.html
What is expected ?
That index.html is at the same location than the bundle so :
index.html -> /bug/dist/simple/index.html

@alwaysonlinetxm
Copy link
Owner

@AlexandreBonaventure Yes, you are right. But it's the default behavior of rollup-plugin-fill-html. That's because I think the result html should just be in the root of a website, and the other resource files can be in nested dirs. Think about this, you generate a html like /bug/dist/simple/index.html, and some resource files, maybe /bug/dist/bundle.js. So what will we see in the html?

<script type="text/javascript" src="../bundle.js"></script>

I think it's not a good way to use '../' in resource file reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants