fix(helix-dap): seq number must start at 1 (helix-editor#14706)

likle · the-mikedavis · alschena · commit 17e86a013451 · 2025-11-13T16:29:09.000+01:00
Co-authored-by: Michael Davis &lt;mcarsondavis@gmail.com&gt;
diff --git a/helix-dap/src/client.rs b/helix-dap/src/client.rs
@@ -231,7 +231,11 @@ impl Client {
     }
 
     fn next_request_id(&self) -> u64 {
-        self.request_counter.fetch_add(1, Ordering::Relaxed)
+        // > The `seq` for the first message sent by a client or debug adapter
+        // > is 1, and for each subsequent message is 1 greater than the
+        // > previous message sent by that actor
+        // <https://microsoft.github.io/debug-adapter-protocol/specification#Base_Protocol_ProtocolMessage>
+        self.request_counter.fetch_add(1, Ordering::Relaxed) + 1
     }
 
     // Internal, called by specific DAP commands when resuming

Original file line number	Diff line number	Diff line change
`@@ -231,7 +231,11 @@ impl Client {`
`231`	`231`	`}`
`232`	`232`
`233`	`233`	`fn next_request_id(&self) -> u64 {`
`234`		`- self.request_counter.fetch_add(1, Ordering::Relaxed)`
	`234`	+ // > The `seq` for the first message sent by a client or debug adapter
	`235`	`+ // > is 1, and for each subsequent message is 1 greater than the`
	`236`	`+ // > previous message sent by that actor`
	`237`	`+ // <https://microsoft.github.io/debug-adapter-protocol/specification#Base_Protocol_ProtocolMessage>`
	`238`	`+ self.request_counter.fetch_add(1, Ordering::Relaxed) + 1`
`235`	`239`	`}`
`236`	`240`
`237`	`241`	`// Internal, called by specific DAP commands when resuming`