-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API documentation issues #334
Comments
On our API docs, we found the generated docs inadequate and essentially re-implemented the entire thing to suit our use-case. There's fairly substantial parts of the OpenAPI spec that aren't covered by the gem's built-in implementation such as polymorphic types (which we've used extensively in our API). For anyone interested, we created a new module which we load in through This is by no means a complete implementation so your mileage may vary. It should still be a useful starting point for anyone wanting to improve their generated docs! |
What should change
After following the guide to generate API documentation from an OpenAPI spec, we've found that Array/List responses are rendered incorrectly - they appear as empty objects.
For example, see: https://ministryofjustice.github.io/hmpps-probation-integration-services/tech-docs/projects/create-and-vary-a-licence-and-delius/api-reference.html#probation-case-crn-addresses
The response should appear as a a list of objects as they do in Swagger, for example: https://create-and-vary-a-licence-and-delius-dev.hmpps.service.justice.gov.uk/swagger-ui/index.html#/probation-case-resource/findAddresses
The text was updated successfully, but these errors were encountered: