Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navigation is broken when deploying on a path #128

Closed
alex-ju opened this issue Oct 17, 2019 · 2 comments
Closed

Navigation is broken when deploying on a path #128

alex-ju opened this issue Oct 17, 2019 · 2 comments
Labels
bug Something isn't working

Comments

@alex-ju
Copy link

alex-ju commented Oct 17, 2019

The left-hand side navigation doesn't look for the defined host (host: https://alphagov.github.io/api-catalogue) generating absolute urls from the root / causing broken links when deployed on GitHub pages (or to a specific folder).

Note: this only happens in a multi-page config.
@alex-ju alex-ju mentioned this issue Oct 17, 2019
Closed
@alex-ju alex-ju mentioned this issue Oct 31, 2019
Closed
@NickColley NickColley added the bug Something isn't working label Nov 1, 2019
@lhokktyn
Copy link

Potential fix (needs reviewing): #84

@alex-ju
Copy link
Author

alex-ju commented Mar 18, 2021

The api-catalogue is now deployed from a subdomain instead of a path. Since this is not a pain point for anyone else I'm happy to close it.

@alex-ju alex-ju closed this as completed Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update multi-page navigation to allow custom path prefix alphagov/tech-docs-gem
3 participants
@alex-ju @lhokktyn @NickColley