Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Resolves #3150
Solution
This is how I imagine the flow to be
Poller starts with params: (filter_id_123,) Makes RPC calls: eth_getFilterChanges(filter_id_123) Server responds: "filter not found" Poller says: "Let me get new params" Poller calls reconnection logic: (old_filter_id) → (new_filter_id) Poller continues with new params: (filter_id_456,)In terms of code, I imagine it to look like this
PS: I kinda tested this, I wasn't able to recreate the filter dropping, couldn't get the right amount of time to wait such that it drops but I did try if it does enter the error if it updates the params with the
with_reconnectfunction. And it does.PR Checklist