Remove PyTorch Lightning integration (#468)

Author: epwalsh

.github/workflows/main.yml

@@ -86,12 +86,6 @@ jobs:
             run: |
               pytest -v --color=yes --doctest-modules tango/integrations/torch tests/integrations/torch
 
-          - name: PyTorch Lightning integration
-            extras: dev,pytorch_lightning
-            requires_torch: true
-            run: |
-              pytest -v --color=yes --doctest-modules tango/integrations/pytorch_lightning tests/integrations/pytorch_lightning
-
           - name: Transformers integration
             extras: dev,flax,transformers
             requires_torch: true

CHANGELOG.md

@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## Unreleased
 
+### Removed
+
+- Removed PyTorch Lightning integration.
+
 ### Fixed
 
 - Fixed issue where Executor `parallelism` option in a Tango settings file would be ignored.

Makefile

@@ -10,6 +10,5 @@ run-checks :
 	flake8 .
 	mypy --check-untyped-defs .
 	CUDA_VISIBLE_DEVICES='' pytest -v --color=yes --doctest-modules --ignore=tests/integrations --ignore=tango/integrations tests/ tango/
-	CUDA_VISIBLE_DEVICES='' pytest -v --color=yes --doctest-modules tango/integrations/pytorch_lightning tests/integrations/pytorch_lightning
 	CUDA_VISIBLE_DEVICES='' pytest -v --color=yes --doctest-modules tango/integrations/torch tests/integrations/torch
 	CUDA_VISIBLE_DEVICES='' pytest -v --color=yes --doctest-modules tango/integrations/transformers tests/integrations/transformers

README.md

@@ -69,7 +69,6 @@ You can pick and choose from the integrations with one of these:
 
 ```bash
 conda install tango-datasets -c conda-forge
-conda install tango-pytorch_lightning -c conda-forge
 conda install tango-torch -c conda-forge
 conda install tango-wandb -c conda-forge
 ```

docs/source/api/integrations/index.rst

@@ -12,6 +12,5 @@ Integrations
    datasets
    transformers
    wandb
-   pytorch_lightning
    beaker
    flax

docs/source/api/integrations/pytorch_lightning.rst

@@ -61,9 +61,6 @@
     "python": ("https://docs.python.org/3", None),
     "rich": ("https://rich.readthedocs.io/en/latest", None),
     "torch": ("https://pytorch.org/docs/stable", None),
-    "pytorch_lightning": ("https://pytorch-lightning.readthedocs.io/en/latest", None),
-    # Just leaving this here for when we do finally add a deepspeed integration:
-    #  "deepspeed": ("https://deepspeed.readthedocs.io/en/latest/", None),
     "flax": ("https://flax.readthedocs.io/en/latest", None),
     "fairscale": ("https://fairscale.readthedocs.io/en/latest/", None),
     "datasets": ("https://huggingface.co/docs/datasets/master/en", None),

docs/source/conf.py

@@ -25,12 +25,11 @@ pytz
 # NOTE: we use a special trailing comment on each line to denote which extras
 # each package is needed by. For example, PyTorch is needed by the 'torch' extra
 # that you install with 'pip install tango[torch]'.
-torch>=1.9,<1.14             # needed by: torch,pytorch_lightning,transformers,fairscale
-numpy                        # needed by: torch,pytorch_lightning,transformers,fairscale
+torch>=1.9,<1.14             # needed by: torch,transformers,fairscale
+numpy                        # needed by: torch,transformers,fairscale
 datasets>=1.12,<3.0          # needed by: datasets,transformers
 wandb>=0.12,<0.14            # needed by: wandb
 retry                        # needed by: wandb
-pytorch-lightning>=1.6,<1.8  # needed by: pytorch_lightning
 transformers>=4.12.3         # needed by: transformers
 sentencepiece==0.1.97        # needed by: transformers
 fairscale>=0.4.6,<0.5        # needed by: fairscale