Skip to content

Commit dd60740

Browse files
authored
Merge pull request #32 from allaboutapps/bug/stub-encoding
Remove dependency from shared APIClient in StubResponse.
2 parents 02299c6 + b906e48 commit dd60740

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

Sources/Fetch/Stub/Stub.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ public struct StubResponse: Stub {
7171
/// - encodable: The object which will be encoded
7272
/// - encoder: The `JSONEncoder` used to encode the `Encodable`
7373
/// - delay: Simulated network delay
74-
public init(statusCode: StatusCode, encodable: Encodable, encoder: ResourceEncoderProtocol = APIClient.shared.config.encoder, headers: HTTPHeaders = HTTPHeaders(), delay: TimeInterval) {
74+
public init(statusCode: StatusCode, encodable: Encodable, encoder: ResourceEncoderProtocol = JSONEncoder(), headers: HTTPHeaders = HTTPHeaders(), delay: TimeInterval) {
7575
self.init(statusCode: statusCode, data: try! encoder.encode(AnyEncodable(encodable)), headers: headers, delay: delay)
7676
}
7777

Tests/FetchTests/StubProviderTests.swift

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ class StubProviderTests: XCTestCase {
3939
}
4040

4141
// update stub
42-
waitForExpectations(timeout: 5, handler: nil)
42+
wait(for: [expectationA], timeout: 5)
4343
let expectationB = self.expectation(description: "Fetch model b")
4444
let stubB = StubResponse(statusCode: 200, encodable: ModelA(a: "b"), delay: 0.1)
4545
APIClient.shared.stubProvider.register(stub: stubB, for: resource)
@@ -54,13 +54,13 @@ class StubProviderTests: XCTestCase {
5454
}
5555
}
5656

57-
waitForExpectations(timeout: 5, handler: nil)
57+
wait(for: [expectationB], timeout: 5)
5858
}
5959

6060
func testRemoveStub() {
6161
let expectation = self.expectation(description: "Fetch model")
6262

63-
let resource = Resource<ModelA>(method: .get, path: "/test")
63+
let resource = Resource<ModelA>(method: .get, path: "/testRemove")
6464

6565
let stub = StubResponse(statusCode: 200, encodable: ModelA(a: "a"), delay: 0.1)
6666
APIClient.shared.stubProvider.register(stub: stub, for: resource)

0 commit comments

Comments
 (0)