Collect 10 Real World Bugs

[alingse]

I want to collect 10 or 100 real world bugs and try add it to golangci-lint

TimeParse

• fix wrong time.Parse params order minio/minio#19279
• fix wrong time.Parse args order bosun-monitor/bosun#2515

RangeAppendAll

• Fix: append all slice data when range for it vmware-tanzu/velero#7602
• Fix: append all slice data when range for it zhuxiujia/GoMybatis#75
• Bug Report: append slice all items when range it open2b/scriggo#948
• Fix: append all slice data when range for it spatial-go/geoos#111
• Fix: append all slice data when range for it vitessio/vitess#16327

[ldez]

FYI the example you are using:

for _, n := range ns {
   rs = append(rs, n)   
   rs = append(rs, ns...)
}

The 2 lines are wrong, in this context the right code is to remove the for:

rs = append(rs, ns...)

A better example could be:

for _, n := range ns {
	if v == "value" {
		rs = append(rs, n)     // OK
		rs = append(rs, ns...) // Bug
	}
}