New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support React Elements as Variables #95

Open

ls-endurance opened this issue Oct 29, 2018 · 9 comments

ls-endurance commented Oct 29, 2018

Here is react-intl supporting elements as variables:

Here's the link: https://github.com/yahoo/react-intl/wiki/Components#rich-text-formatting

richseviora commented Oct 30, 2018

The specific implementation appears to be here: https://github.com/yahoo/react-intl/blob/master/src/components/message.js#L105-L147

Author

ls-endurance commented Oct 31, 2018

That's perfect. I might crack up react-intl-universal and make the PR.

richseviora commented Oct 31, 2018

Awesome :D I'm glad I could help a bit :)

Author

ls-endurance commented Nov 1, 2018

take a look at this PR
#98

Author

ls-endurance commented Nov 1, 2018

let me know if im missing something

Collaborator

cwtuan commented Nov 2, 2018 •

edited

Loading

@ls-endurance Could you please add some description in README? Thanks!

Author

ls-endurance commented Nov 2, 2018

@cwtuan Sure! I'll get on that today.

Author

ls-endurance commented Nov 2, 2018

Readme is updated.

walirt commented Dec 10, 2021 •

edited

Loading

Is this feature not merge into the master branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment