-
Notifications
You must be signed in to change notification settings - Fork 2.1k
feat: support react-router fallbackElement and loading example #7145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ClarkXia
wants to merge
2
commits into
master
Choose a base branch
from
feat/support-fallback-element
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| import { defineConfig } from '@ice/app'; | ||
|
|
||
| export default defineConfig(() => ({ | ||
| ssg: false, | ||
| })); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| { | ||
| "name": "@ice/example-with-fallback-element", | ||
| "private": true, | ||
| "version": "1.0.0", | ||
| "description": "Example demonstrating custom fallbackElement configuration in app.tsx", | ||
| "dependencies": { | ||
| "react": "^18.0.0", | ||
| "react-dom": "^18.0.0", | ||
| "@ice/runtime": "workspace:*" | ||
| }, | ||
| "devDependencies": { | ||
| "@ice/app": "workspace:*", | ||
| "@types/react": "^18.0.0", | ||
| "@types/react-dom": "^18.0.0" | ||
| }, | ||
| "scripts": { | ||
| "start": "ice start", | ||
| "build": "ice build" | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| import React from 'react'; | ||
| import { defineAppConfig } from 'ice'; | ||
|
|
||
| // Custom fallback element. | ||
| const CustomFallback = () => ( | ||
| <div | ||
| style={{ | ||
| display: 'flex', | ||
| justifyContent: 'center', | ||
| alignItems: 'center', | ||
| height: '100vh', | ||
| fontSize: '18px', | ||
| color: '#666', | ||
| }} | ||
| > | ||
| <div> | ||
| <div>🔄 Loading...</div> | ||
| <div style={{ fontSize: '14px', marginTop: '8px' }}> | ||
| Custom fallback element from app.tsx configuration | ||
| </div> | ||
| </div> | ||
| </div> | ||
| ); | ||
|
|
||
| export default defineAppConfig({ | ||
| app: { | ||
| rootId: 'app', | ||
| }, | ||
| router: { | ||
| type: 'hash', | ||
| fallbackElement: <CustomFallback />, | ||
| }, | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| import React from 'react'; | ||
|
|
||
| export default function Home() { | ||
| return ( | ||
| <div> | ||
| <h2 style={{ textAlign: 'center', padding: '20px' }}> | ||
| Home Page | ||
| </h2> | ||
| <div style={{ textAlign: 'center' }}> | ||
| Welcome to the Home Page! | ||
| </div> | ||
| </div> | ||
| ); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| import React from 'react'; | ||
| import { Link } from 'ice'; | ||
|
|
||
| export default function Home() { | ||
| return ( | ||
| <div> | ||
| <h2 style={{ textAlign: 'center', padding: '20px' }}> | ||
| Test Page | ||
| </h2> | ||
| <div style={{ textAlign: 'center' }}> | ||
| <Link to="/home">Go to Home Page</Link> | ||
| </div> | ||
| </div> | ||
| ); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| import React from 'react'; | ||
| import { useNavigation, Outlet } from 'ice'; | ||
|
|
||
| export default function Home() { | ||
| const navigation = useNavigation(); | ||
| // Use navigation state to determine loading status, and show loading indicator. | ||
| const isLoading = navigation.state === 'loading'; | ||
| return ( | ||
| <div> | ||
| {isLoading && (<div>loading</div>)} | ||
| <Outlet /> | ||
| </div> | ||
| ); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,6 +7,7 @@ const defaultAppConfig: AppConfig = { | |
| }, | ||
| router: { | ||
| type: 'browser', | ||
| fallbackElement: null, | ||
| }, | ||
| }; | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.