Skip to content

fix: rootId not working when integrating with single-spa (fix #7128) #7141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: rootId not working when integrating with single-spa (fix #7128) #7141

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions packages/plugin-icestark/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ const PLUGIN_NAME = '@ice/plugin-icestark';
const plugin: Plugin<PluginOptions> = ({ type, library }) => ({
name: PLUGIN_NAME,
setup: ({ onGetConfig, context, generator, modifyUserConfig }) => {
const libraryName = library || context.pkg?.name as string || 'microApp';
const libraryName = library || (context.pkg?.name as string) || 'microApp';
onGetConfig((config) => {
config.configureWebpack ??= [];
config.configureWebpack.push((webpackConfig) => {
Expand Down Expand Up @@ -52,12 +52,13 @@ export async function mount(props) {
// Props of container if conflict with render node in ice, it may cause node overwritten.
let runtimeOptions = props;
if (props.singleSpa) {
const iceContainer = props.container?.querySelector('#ice-container');
const targetId = app?.default?.app?.rootId || 'ice-container'
const iceContainer = props.container?.querySelector('#' + targetId);
if (iceContainer) {
runtimeOptions = {...props, container: iceContainer };
} else {
const ele = document.createElement('div');
ele.id = 'ice-container';
ele.id = targetId;
props.container.appendChild(ele);
runtimeOptions = {...props, container: ele };
}
Expand All @@ -72,7 +73,7 @@ export async function unmount(props) {
// Reset root to null when app unmount.
root = null;
}`;
});
});
} else {
// Plugin icestark do not support ssr yet.
modifyUserConfig('ssr', false);
Expand Down