Skip to content

Conversation

@ClarkXia
Copy link
Collaborator

@ClarkXia ClarkXia commented Aug 7, 2025

This pull request updates the CSS Modules plugin integration across the build pipeline to support path alias resolution, improving how CSS module imports are handled in projects with custom path aliases. The main changes involve passing alias configuration to the CSS Modules plugin and updating its internal logic to resolve paths using these aliases.

@ClarkXia ClarkXia requested a review from Copilot August 20, 2025 02:13
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request enhances the CSS Modules plugin to support path alias resolution, allowing CSS module imports to work correctly with custom path aliases defined in the project configuration. The changes ensure that when CSS modules are imported using aliases, they are properly resolved to their actual file paths during the build process.

Key changes:

  • Added alias configuration parameter to CSS Modules plugin across multiple build services
  • Integrated alias resolution logic into the CSS module path resolution process
  • Exported the AliasWithEmpty type for reuse in the CSS modules plugin

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
packages/ice/src/service/serverCompiler.ts Passes alias configuration to cssModulesPlugin
packages/ice/src/service/preBundleDeps.ts Adds alias parameter to cssModulesPlugin call
packages/ice/src/service/analyze.ts Exports AliasWithEmpty type for use in other modules
packages/ice/src/service/ServerRunner.ts Includes alias configuration in cssModulesPlugin setup
packages/ice/src/esbuild/cssModules.ts Implements alias resolution logic in the CSS modules plugin

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@ClarkXia ClarkXia changed the base branch from master to release/next August 21, 2025 02:58
Base automatically changed from release/next to master August 27, 2025 08:05
@ClarkXia ClarkXia changed the base branch from master to release/next September 3, 2025 08:52
@ClarkXia ClarkXia requested review from XGHeaven and XXXMrG September 3, 2025 08:53
Copy link
Collaborator

@XGHeaven XGHeaven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a changeset?

@ClarkXia
Copy link
Collaborator Author

ClarkXia commented Sep 9, 2025

Add a changeset?

DONE

@ClarkXia ClarkXia requested a review from XGHeaven September 9, 2025 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants