Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Internationalization (other languages) #16

Open
alganzory opened this issue Oct 30, 2023 · 5 comments
Open

Support Internationalization (other languages) #16

alganzory opened this issue Oct 30, 2023 · 5 comments
Assignees
Labels
enhancement New feature or request low priority

Comments

@alganzory
Copy link
Owner

No description provided.

@alganzory alganzory added enhancement New feature or request low priority labels Nov 3, 2023
@anonfaded
Copy link
Contributor

Working on this feature brother, can you assign this issue to me :)

@alganzory
Copy link
Owner Author

Thanks @anonfaded

@anonfaded
Copy link
Contributor

Brother i have added arabic language to the HaramBlur extension but there are some issues which i can't figure out so need guidance.

I did two things:

  1. Added IDs in the tags in popup.html file.
  2. Added translations.js file which contains the translations.

But the issue is with the tooltip, the blur and the strictness % value which isn't showing on both english and arabic version which you can see in the attached screenshot below.
Screenshot from 2023-12-16 18-14-03

The buttons of grayscale, image etc all are working fine and it blurs the images but it doesn't show the percentage.

Also when i load the extension it loads like you saw above but when i upload the unzipped extension which we get from npm run release command, then the arabic translation when picked from the dropdown doesn't work and also the tooltip and % is visible as it is now in the online extension.

Sharing a fullscreen screenshot below and waiting for your suggestion on what to do now, should i open the pull request if you can handle the rest? or any guidance on how to fix this issue.
Screenshot from 2023-12-16 20-22-33

Check the code here:

https://github.com/anonfaded/HaramBlur

@alganzory
Copy link
Owner Author

Thank you for your efforts, May Allah bless you

I think it's best if you open a PR first and then I'll look at the changes and see what could be causing the bugs. For one, I think the build problem you're getting is because you haven't added the new files to the release command in package.json.
But again, please open a PR so I can look into it further

Jazak Allahu Khairan

@anonfaded
Copy link
Contributor

yes please review the code, and I'm here for any further steps that i may have missed.
If everything goes fine and we find the solution then i will recheck the translations and will correct them after i verify that from arabic speaking friend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request low priority
Projects
None yet
Development

No branches or pull requests

2 participants