Allow scoring tools to finish naturally instead of breaking early (#337)

djkunkel · web-flow · commit fb11bc920c68 · 2026-01-31T14:29:43.000Z
Previously, the code would break out of the loop as soon as the score was
calculated, but before the underlying process had fully completed. This could
cause process cleanup issues and race conditions. Now the code continues
processing until the stream naturally ends, ensuring proper cleanup.
diff --git a/src/command/sample_encode.rs b/src/command/sample_encode.rs
@@ -318,7 +318,6 @@ pub fn run(
                                 match vmaf {
                                     VmafOut::Done(score) => {
                                         vmaf_score = Some(score);
-                                        break;
                                     }
                                     VmafOut::Progress(FfmpegOut::Progress { time, fps, .. }) => {
                                         yield Update::Status(Status {
@@ -375,7 +374,6 @@ pub fn run(
                                 match next {
                                     XpsnrOut::Done(s) => {
                                         score = Some(s);
-                                        break;
                                     }
                                     XpsnrOut::Progress(FfmpegOut::Progress { time, fps, .. }) => {
                                         yield Update::Status(Status {
diff --git a/src/command/vmaf.rs b/src/command/vmaf.rs
@@ -83,7 +83,6 @@ pub async fn vmaf(
         match vmaf {
             VmafOut::Done(score) => {
                 vmaf_score = Some(score);
-                break;
             }
             VmafOut::Progress(FfmpegOut::Progress {
                 frame, fps, time, ..
diff --git a/src/command/xpsnr.rs b/src/command/xpsnr.rs
@@ -79,7 +79,6 @@ pub async fn xpsnr(
         match next {
             XpsnrOut::Done(s) => {
                 score = Some(s);
-                break;
             }
             XpsnrOut::Progress(FfmpegOut::Progress {
                 frame, fps, time, ..

Original file line number	Diff line number	Diff line change
`@@ -83,7 +83,6 @@ pub async fn vmaf(`
`83`	`83`	`match vmaf {`
`84`	`84`	`VmafOut::Done(score) => {`
`85`	`85`	`vmaf_score = Some(score);`
`86`		`- break;`
`87`	`86`	`}`
`88`	`87`	`VmafOut::Progress(FfmpegOut::Progress {`
`89`	`88`	`frame, fps, time, ..`
Original file line number	Diff line number	Diff line change
`@@ -79,7 +79,6 @@ pub async fn xpsnr(`
`79`	`79`	`match next {`
`80`	`80`	`XpsnrOut::Done(s) => {`
`81`	`81`	`score = Some(s);`
`82`		`- break;`
`83`	`82`	`}`
`84`	`83`	`XpsnrOut::Progress(FfmpegOut::Progress {`
`85`	`84`	`frame, fps, time, ..`