Merge pull request #160 from mulimoen/bugfix/dont_atexit

Prevent hdf5 calling atexit()

Author: mulimoen

CHANGELOG.md

@@ -71,6 +71,7 @@
   are now generic over size only: `FixedAscii<N>` and `FixedUnicode<N>`.
 - The version of `hdf5` built in `hdf5-src` has been updated from `1.10.6` to `1.10.7`.
 - The `zlib` dependency is no longer included with `default-features`.
+- `hdf5` no longer calls `H5close` automatically on program exit.
 
 ## 0.7.1
 

src/globals.rs

@@ -18,7 +18,12 @@ use crate::internal_prelude::*;
 
 lazy_static! {
     static ref LIBRARY_INIT: () = {
-        h5lock!(::hdf5_sys::h5::H5open());
+        h5lock!({
+            // Ensure hdf5 does not invalidate handles which might
+            // still be live on other threads on program exit
+            ::hdf5_sys::h5::H5dont_atexit();
+            ::hdf5_sys::h5::H5open();
+        });
         let _e = crate::hl::filters::register_filters();
     };
 }

src/hl/plist/dataset_create.rs

@@ -729,7 +729,7 @@ impl DatasetCreate {
                 h5try!(H5Pget_fill_value(self.id(), dtype.id(), buf.as_mut_ptr().cast()));
                 Ok(Some(unsafe { OwnedDynValue::from_raw(tp.clone(), buf) }))
             }
-            _ => Ok(None),
+            FillValue::Undefined => Ok(None),
         }
     }
 

src/hl/plist/file_create.rs

@@ -413,7 +413,9 @@ impl FileCreateBuilder {
                     FileSpaceStrategy::PageAggregation => {
                         (H5F_fspace_strategy_t::H5F_FSPACE_STRATEGY_AGGR, 0, 0)
                     }
-                    _ => (H5F_fspace_strategy_t::H5F_FSPACE_STRATEGY_NONE, 0, 0),
+                    FileSpaceStrategy::None => {
+                        (H5F_fspace_strategy_t::H5F_FSPACE_STRATEGY_NONE, 0, 0)
+                    }
                 };
                 h5try!(H5Pset_file_space_strategy(id, strategy, persist, threshold));
             }

src/hl/selection.rs

@@ -448,7 +448,7 @@ where
     Dout: ndarray::Dimension,
 {
     fn from(slice: ndarray::SliceInfo<T, Din, Dout>) -> Self {
-        slice.deref().as_ref().iter().cloned().map(Into::into).collect::<Vec<_>>().into()
+        slice.deref().as_ref().iter().copied().map(Into::into).collect::<Vec<_>>().into()
     }
 }