Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chartFrom() func needs at least two argument #3206

Closed
4 tasks done
N214 opened this issue Jan 3, 2025 · 2 comments
Closed
4 tasks done

chartFrom() func needs at least two argument #3206

N214 opened this issue Jan 3, 2025 · 2 comments

Comments

@N214
Copy link

N214 commented Jan 3, 2025

Checklist

  • I've searched the issue queue to verify this is not a duplicate bug report.
  • I've included steps to reproduce the bug.
  • I've pasted the output of kargo version.
  • I've pasted logs, if applicable.

Description

From the doc https://github.com/akuity/kargo/blob/main/docs/docs/35-references/10-promotion-steps.md?plain=1#L745
chartFrom() takes chartRepo as argument, but from the code we can see that chartName is a empty var, thus FindChart will always return an error.

Screenshots

image
@krancour
Copy link
Member

krancour commented Jan 4, 2025

This is a (subtle) mistake in the docs... I'd meant for that to be an oci repo.

For oci repos, you only need to provide the repo URL, but classic http/s chart repos are more like a "registry" in that versions of multiple different charts can be stored in a single repo. That requires you to specify a chart name as a second arg.

I'll fix the docs, but please do let me know if this clarification gets you moving again.

@N214
Copy link
Author

N214 commented Jan 4, 2025

Thank you for clarifying, there is not blocking issue. Awesome project !

@N214 N214 closed this as completed Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants