Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accepts works only for Automata that support getRulesBottomUp #12

Open
akoehn opened this issue Sep 7, 2015 · 3 comments
Open

Accepts works only for Automata that support getRulesBottomUp #12

akoehn opened this issue Sep 7, 2015 · 3 comments
Labels
bug Something isn't working minor

Comments

@akoehn
Copy link
Owner

akoehn commented Sep 7, 2015

Original report by Christoph Teichmann (Bitbucket: cteichmann, GitHub: cteichmann).


TreeAutomaton.accepts(Tree) relies on run(Tree) which in turn relies on runRaw(Tree), which only works if the automaton supports getRulesBottomUp, in the interest of supporting specialized implementations the method should check what kind of queries the the automaton actually supports and then use an analogue of run(Tree) which works top down instead of bottom up (even if that means that we may be unable to exploit bottom up determinism).

@akoehn
Copy link
Owner Author

akoehn commented Sep 7, 2015

Original changes by Christoph Teichmann (Bitbucket: cteichmann, GitHub: cteichmann).


changed priority from "major" to "minor"

@akoehn
Copy link
Owner Author

akoehn commented Aug 23, 2017

Original comment by Christoph Teichmann (Bitbucket: cteichmann, GitHub: cteichmann).


I should also check the weight computation for compatibility with top down questions.

@akoehn
Copy link
Owner Author

akoehn commented Aug 23, 2017

Original changes by Christoph Teichmann (Bitbucket: cteichmann, GitHub: cteichmann).


changed state from "new" to "open"

@akoehn akoehn added minor bug Something isn't working labels Mar 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working minor
Projects
None yet
Development

No branches or pull requests

1 participant