Skip to content

Commit f3d89ed

Browse files
xainazxainaz
andauthored
Added name to update (#245)
Co-authored-by: xainaz <[email protected]>
1 parent 50d7c6a commit f3d89ed

File tree

2 files changed

+14
-7
lines changed

2 files changed

+14
-7
lines changed

aixplain/modules/pipeline/asset.py

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -262,10 +262,11 @@ def __prepare_payload(
262262
dasset = DatasetFactory.get(str(data_asset[node_label]))
263263
asset_payload["dataAsset"]["dataset_id"] = dasset.id
264264

265-
if (
266-
len([dfield for dfield in dasset.source_data if dasset.source_data[dfield].id == data[node_label]])
267-
> 0
268-
):
265+
source_data_list = [
266+
dfield for dfield in dasset.source_data if dasset.source_data[dfield].id == data[node_label]
267+
]
268+
269+
if len(source_data_list) > 0:
269270
data_found = True
270271
else:
271272
for target in dasset.target_data:
@@ -341,9 +342,11 @@ def run_async(
341342
error = "Validation-related error: Please ensure all required fields are provided and correctly formatted."
342343
else:
343344
status_code = str(r.status_code)
344-
error = f"Status {status_code}: Unspecified error: An unspecified error occurred while processing your request."
345+
error = (
346+
f"Status {status_code}: Unspecified error: An unspecified error occurred while processing your request."
347+
)
345348
response = {"status": "FAILED", "error_message": error}
346-
logging.error(f"Error in request for {name} - {r.status_code}: {error}")
349+
logging.error(f"Error in request for {name} - {r.status_code}: {error}")
347350
except Exception:
348351
response = {"status": "FAILED"}
349352
if resp is not None:
@@ -355,6 +358,7 @@ def update(
355358
pipeline: Union[Text, Dict],
356359
save_as_asset: bool = False,
357360
api_key: Optional[Text] = None,
361+
name: Optional[Text] = None,
358362
):
359363
"""Update Pipeline
360364
@@ -382,6 +386,8 @@ def update(
382386
status = "draft"
383387
if save_as_asset is True:
384388
status = "onboarded"
389+
if name:
390+
self.name = name
385391
payload = {
386392
"name": self.name,
387393
"status": status,

tests/functional/pipelines/create_test.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,8 @@ def test_update_pipeline():
5454
pipeline_name = str(uuid4())
5555
pipeline = PipelineFactory.create(name=pipeline_name, pipeline=pipeline_dict)
5656

57-
pipeline.update(pipeline=pipeline_json, save_as_asset=True)
57+
pipeline.update(pipeline=pipeline_json, save_as_asset=True, name="NEW NAME")
58+
assert pipeline.name == "NEW NAME"
5859
assert isinstance(pipeline, Pipeline)
5960
assert pipeline.id != ""
6061
pipeline.delete()

0 commit comments

Comments
 (0)