From 1b42393d73c57fb1980b8faae55625ffc59f72b3 Mon Sep 17 00:00:00 2001 From: Jash Date: Mon, 16 Dec 2024 03:10:41 +0530 Subject: [PATCH 1/2] Descriptive commit message --- README.md | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index 9a325a355b..9519bf0db8 100644 --- a/README.md +++ b/README.md @@ -3183,6 +3183,11 @@ Other Style Guides inventorOf, ); + //good + export const MY_EXPORTED_FUNCTION = () => { + return 'hello function'; +}; + // good (note that a comma must not appear after a "rest" element) createHero( firstName, @@ -3546,7 +3551,7 @@ Other Style Guides const PRIVATE_VARIABLE = 'should not be unnecessarily uppercased within a file'; // bad - export const THING_TO_BE_CHANGED = 'should obviously not be uppercased'; + export const MY_CONSTANT = 'should obviously not be uppercased'; // bad export let REASSIGNABLE_VARIABLE = 'do not use let with uppercase variables'; From af74cec5d7b592aad5f4d09c37d5e38583ab6a4e Mon Sep 17 00:00:00 2001 From: JASH9898567 <146139028+JASH9898567@users.noreply.github.com> Date: Mon, 16 Dec 2024 12:15:58 +0530 Subject: [PATCH 2/2] Update README.md Co-authored-by: Jordan Harband --- README.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index 9519bf0db8..3012aebb30 100644 --- a/README.md +++ b/README.md @@ -3184,9 +3184,9 @@ Other Style Guides ); //good - export const MY_EXPORTED_FUNCTION = () => { - return 'hello function'; -}; + export function MY_EXPORTED_FUNCTION() { + return 'hello function'; + }; // good (note that a comma must not appear after a "rest" element) createHero(