bump rocksdb version

[raphaelauv]

I would like to try rocksdb with IOUring ( async operations ) , did you not bump the version of rocksdb for a reason , or it's just not necessary for your current usage ? thanks

[breakds]

Same questions here. It seems that aimrocks cannot only build with rocksdb 6.x while the latest version is 9.x. Is there a plan to upgrade to use the latest rocksdb?

[flokli]

Also interested in this. Errors observed during build, if passing it rocksdb 9.x:

g++ -fno-strict-overflow -Wsign-compare -DNDEBUG -g -O3 -Wall -I/nix/store/9zc23bbx3c0avymh8ib2lapsz6hxmcwb-libxcrypt-4.4.38/include -fPIC -I/nix/store/98z87sq7mqncs1xzf6lza7q4gm3y1xcn-rocksdb-9.10.0/include/ -I/build/source/src/aimrocks/include -I/nix/store/ic0fd07z8wg57idmw7q7iy7dc7md6x72-python3-3.12.9/include/python3.12 -c src/aimrocks/lib_rocksdb.cpp -o build/temp.linux-aarch64-cpython-312/src/aimrocks/lib_rocksdb.o -std=c++11 -O3 -Wall -Wextra -Wconversion -fno-strict-aliasing -fno-rtti -fPIC
In file included from src/aimrocks/lib_rocksdb.cpp:1326:
/build/source/src/aimrocks/include/rocksdb/slice.h:46:20: error: ‘string_view’ in namespace ‘std’ does not name a type
   46 |   Slice(const std::string_view& sv) : data_(sv.data()), size_(sv.size()) {}
      |                    ^~~~~~~~~~~
/build/source/src/aimrocks/include/rocksdb/slice.h:46:15: note: ‘std::string_view’ is only available from C++17 onwards
   46 |   Slice(const std::string_view& sv) : data_(sv.data()), size_(sv.size()) {}
      |               ^~~
/build/source/src/aimrocks/include/rocksdb/slice.h:95:8: error: ‘string_view’ in namespace ‘std’ does not name a type
   95 |   std::string_view ToStringView() const {
      |        ^~~~~~~~~~~
/build/source/src/aimrocks/include/rocksdb/slice.h:95:3: note: ‘std::string_view’ is only available from C++17 onwards
   95 |   std::string_view ToStringView() const {
      |   ^~~
/build/source/src/aimrocks/include/rocksdb/slice.h: In constructor ‘rocksdb::Slice::Slice(const int&)’:
/build/source/src/aimrocks/include/rocksdb/slice.h:46:48: error: request for member ‘data’ in ‘sv’, which is of non-class type ‘const int’
   46 |   Slice(const std::string_view& sv) : data_(sv.data()), size_(sv.size()) {}
      |                                                ^~~~
/build/source/src/aimrocks/include/rocksdb/slice.h:46:66: error: request for member ‘size’ in ‘sv’, which is of non-class type ‘const int’
   46 |   Slice(const std::string_view& sv) : data_(sv.data()), size_(sv.size()) {}
      |                                                                  ^~~~
In file included from /build/source/src/aimrocks/include/rocksdb/merge_operator.h:17,
                 from src/aimrocks/lib_rocksdb.cpp:1330:
/build/source/src/aimrocks/include/rocksdb/wide_columns.h: In constructor ‘rocksdb::WideColumn::WideColumn(std::piecewise_construct_t, NTuple&&, VTuple&&)’:
/build/source/src/aimrocks/include/rocksdb/wide_columns.h:52:20: error: ‘make_from_tuple’ is not a member of ‘std’
   52 |       : name_(std::make_from_tuple<Slice>(std::forward<NTuple>(name_tuple))),
      |                    ^~~~~~~~~~~~~~~
/build/source/src/aimrocks/include/rocksdb/wide_columns.h:52:20: note: ‘std::make_from_tuple’ is only available from C++17 onwards
/build/source/src/aimrocks/include/rocksdb/wide_columns.h:52:41: error: expected primary-expression before ‘>’ token
   52 |       : name_(std::make_from_tuple<Slice>(std::forward<NTuple>(name_tuple))),
      |                                         ^
/build/source/src/aimrocks/include/rocksdb/wide_columns.h:53:21: error: ‘make_from_tuple’ is not a member of ‘std’
   53 |         value_(std::make_from_tuple<Slice>(std::forward<VTuple>(value_tuple))) {
      |                     ^~~~~~~~~~~~~~~
/build/source/src/aimrocks/include/rocksdb/wide_columns.h:53:21: note: ‘std::make_from_tuple’ is only available from C++17 onwards
/build/source/src/aimrocks/include/rocksdb/wide_columns.h:53:42: error: expected primary-expression before ‘>’ token
   53 |         value_(std::make_from_tuple<Slice>(std::forward<VTuple>(value_tuple))) {
      |                                          ^
/build/source/src/aimrocks/include/rocksdb/merge_operator.h: At global scope:
/build/source/src/aimrocks/include/rocksdb/merge_operator.h:165:32: error: ‘variant’ in namespace ‘std’ does not name a template type
  165 |     using ExistingValue = std::variant<std::monostate, Slice, WideColumns>;
      |                                ^~~~~~~
/build/source/src/aimrocks/include/rocksdb/merge_operator.h:165:27: note: ‘std::variant’ is only available from C++17 onwards
  165 |     using ExistingValue = std::variant<std::monostate, Slice, WideColumns>;
      |                           ^~~
/build/source/src/aimrocks/include/rocksdb/merge_operator.h:169:36: error: ‘ExistingValue’ has not been declared
  169 |                                    ExistingValue&& _existing_value,
      |                                    ^~~~~~~~~~~~~
/build/source/src/aimrocks/include/rocksdb/merge_operator.h:182:5: error: ‘ExistingValue’ does not name a type
  182 |     ExistingValue existing_value;
      |     ^~~~~~~~~~~~~
/build/source/src/aimrocks/include/rocksdb/merge_operator.h:191:27: error: ‘variant’ in namespace ‘std’ does not name a template type
  191 |     using NewValue = std::variant<std::string, NewColumns, Slice>;
      |                           ^~~~~~~
/build/source/src/aimrocks/include/rocksdb/merge_operator.h:191:22: note: ‘std::variant’ is only available from C++17 onwards
  191 |     using NewValue = std::variant<std::string, NewColumns, Slice>;
      |                      ^~~
/build/source/src/aimrocks/include/rocksdb/merge_operator.h:196:5: error: ‘NewValue’ does not name a type
  196 |     NewValue new_value;
      |     ^~~~~~~~
/build/source/src/aimrocks/include/rocksdb/merge_operator.h: In constructor ‘rocksdb::MergeOperator::MergeOperationInputV3::MergeOperationInputV3(const rocksdb::Slice&, int&&, const OperandList&, rocksdb::Logger*)’:
/build/source/src/aimrocks/include/rocksdb/merge_operator.h:173:11: error: class ‘rocksdb::MergeOperator::MergeOperationInputV3’ does not have any field named ‘existing_value’
  173 |           existing_value(std::move(_existing_value)),
      |           ^~~~~~~~~~~~~~
In file included from /build/source/src/aimrocks/include/rocksdb/cache.h:20,
                 from /build/source/src/aimrocks/include/rocksdb/advanced_options.h:13,
                 from /build/source/src/aimrocks/include/rocksdb/options.h:21,
                 from /build/source/src/aimrocks/include/rocksdb/block_cache_trace_writer.h:8,
                 from /build/source/src/aimrocks/include/rocksdb/db.h:21,
                 from src/aimrocks/lib_rocksdb.cpp:1332:
/build/source/src/aimrocks/include/rocksdb/data_structure.h: In constructor ‘rocksdb::SmallEnumSet<ENUM_TYPE, MAX_ENUMERATOR>::SmallEnumSet(ENUM_TYPE, TRest ...)’:
/build/source/src/aimrocks/include/rocksdb/data_structure.h:42:3: error: ‘constexpr’ constructor does not have empty body
   42 |   }
      |   ^
/build/source/src/aimrocks/include/rocksdb/options.h: At global scope:
/build/source/src/aimrocks/include/rocksdb/options.h:1747:8: error: ‘optional’ in namespace ‘std’ does not name a template type
 1747 |   std::optional<size_t> merge_operand_count_threshold;
      |        ^~~~~~~~
/build/source/src/aimrocks/include/rocksdb/options.h:1747:3: note: ‘std::optional’ is only available from C++17 onwards
 1747 |   std::optional<size_t> merge_operand_count_threshold;
      |   ^~~
In file included from /build/source/src/aimrocks/include/rocksdb/db.h:32:
/build/source/src/aimrocks/include/rocksdb/utilities/table_properties_collectors.h: In member function ‘double rocksdb::DataCollectionUnixWriteTimeInfo::TrackedDataRatio() const’:
/build/source/src/aimrocks/include/rocksdb/utilities/table_properties_collectors.h:199:12: warning: conversion from ‘uint64_t’ {aka ‘long unsigned int’} to ‘double’ may change value [8;;https://gcc.gnu.org/onlinedocs/gcc-14.2.0/gcc/Warning-Options.html#index-Wconversion-Wconversion8;;]
  199 |     return num_entries_write_time_tracked /
      |            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/aimrocks/lib_rocksdb.cpp: In function ‘int __pyx_pf_8aimrocks_11lib_rocksdb_21PyGenericFilterPolicy___cinit__(__pyx_obj_8aimrocks_11lib_rocksdb_PyGenericFilterPolicy*, PyObject*)’:
src/aimrocks/lib_rocksdb.cpp:14092:194: error: invalid new-expression of abstract class type ‘py_rocks::FilterPolicyWrapper’
14092 |     __pyx_t_8 = new py_rocks::FilterPolicyWrapper(__pyx_t_7, ((void *)__pyx_v_ob), __pyx_f_8aimrocks_11lib_rocksdb_create_filter_callback, __pyx_f_8aimrocks_11lib_rocksdb_key_may_match_callback);
      |                                                                                                                                                                                                  ^
In file included from src/aimrocks/lib_rocksdb.cpp:1337:
/build/source/src/aimrocks/include/rdb_include/filter_policy_wrapper.hpp:11:11: note:   because the following virtual functions are pure within ‘py_rocks::FilterPolicyWrapper’:
   11 |     class FilterPolicyWrapper: public FilterPolicy {
      |           ^~~~~~~~~~~~~~~~~~~
In file included from src/aimrocks/lib_rocksdb.cpp:1336:
/build/source/src/aimrocks/include/rocksdb/filter_policy.h:105:23: note:     ‘virtual const char* rocksdb::FilterPolicy::CompatibilityName() const’
  105 |   virtual const char* CompatibilityName() const = 0;
      |                       ^~~~~~~~~~~~~~~~~
/build/source/src/aimrocks/include/rocksdb/filter_policy.h:124:30: note:     ‘virtual rocksdb::FilterBitsBuilder* rocksdb::FilterPolicy::GetBuilderWithContext(const rocksdb::FilterBuildingContext&) const’
  124 |   virtual FilterBitsBuilder* GetBuilderWithContext(
      |                              ^~~~~~~~~~~~~~~~~~~~~
/build/source/src/aimrocks/include/rocksdb/filter_policy.h:132:29: note:     ‘virtual rocksdb::FilterBitsReader* rocksdb::FilterPolicy::GetFilterBitsReader(const rocksdb::Slice&) const’
  132 |   virtual FilterBitsReader* GetFilterBitsReader(
      |                             ^~~~~~~~~~~~~~~~~~~
src/aimrocks/lib_rocksdb.cpp: In function ‘PyObject* __pyx_f_8aimrocks_11lib_rocksdb_19PyBloomFilterPolicy_create_filter(__pyx_obj_8aimrocks_11lib_rocksdb_PyBloomFilterPolicy*, PyObject*, int)’:
src/aimrocks/lib_rocksdb.cpp:15697:16: error: ‘__pyx_t_8aimrocks_11lib_rocksdb_ConstFilterPolicy’ {aka ‘const class rocksdb::FilterPolicy’} has no member named ‘CreateFilter’
15697 |     __pyx_t_9->CreateFilter(py_rocks::vector_data(__pyx_v_c_keys), ((int)__pyx_v_c_keys.size()), (&__pyx_v_dst));
      |                ^~~~~~~~~~~~
src/aimrocks/lib_rocksdb.cpp: In function ‘PyObject* __pyx_f_8aimrocks_11lib_rocksdb_19PyBloomFilterPolicy_key_may_match(__pyx_obj_8aimrocks_11lib_rocksdb_PyBloomFilterPolicy*, PyObject*, PyObject*, int)’:
src/aimrocks/lib_rocksdb.cpp:15988:28: error: ‘__pyx_t_8aimrocks_11lib_rocksdb_ConstFilterPolicy’ {aka ‘const class rocksdb::FilterPolicy’} has no member named ‘KeyMayMatch’
15988 |     __pyx_t_9 = __pyx_t_6->KeyMayMatch(__pyx_t_7, __pyx_t_8);
      |                            ^~~~~~~~~~~
src/aimrocks/lib_rocksdb.cpp: In function ‘int __pyx_pf_8aimrocks_11lib_rocksdb_22BlockBasedTableFactory___init__(__pyx_obj_8aimrocks_11lib_rocksdb_BlockBasedTableFactory*, PyObject*, PyLongObject*, PyObject*, __pyx_obj_8aimrocks_11lib_rocksdb_PyCache*, __pyx_obj_8aimrocks_11lib_rocksdb_PyCache*, PyObject*, PyObject*, PyObject*, PyObject*, PyObject*, PyObject*)’:
src/aimrocks/lib_rocksdb.cpp:21421:27: error: ‘struct rocksdb::BlockBasedTableOptions’ has no member named ‘hash_index_allow_collision’
21421 |     __pyx_v_table_options.hash_index_allow_collision = 1;
      |                           ^~~~~~~~~~~~~~~~~~~~~~~~~~
src/aimrocks/lib_rocksdb.cpp:21441:27: error: ‘struct rocksdb::BlockBasedTableOptions’ has no member named ‘hash_index_allow_collision’
21441 |     __pyx_v_table_options.hash_index_allow_collision = 0;
      |                           ^~~~~~~~~~~~~~~~~~~~~~~~~~
src/aimrocks/lib_rocksdb.cpp:21757:27: error: ‘struct rocksdb::BlockBasedTableOptions’ has no member named ‘block_cache_compressed’
21757 |     __pyx_v_table_options.block_cache_compressed = __PYX_STD_MOVE_IF_SUPPORTED(__pyx_t_6);
      |                           ^~~~~~~~~~~~~~~~~~~~~~
src/aimrocks/lib_rocksdb.cpp: In function ‘PyObject* __pyx_pf_8aimrocks_11lib_rocksdb_19ColumnFamilyOptions_24max_mem_compaction_level___get__(__pyx_obj_8aimrocks_11lib_rocksdb_ColumnFamilyOptions*)’:
src/aimrocks/lib_rocksdb.cpp:30366:57: error: ‘struct rocksdb::ColumnFamilyOptions’ has no member named ‘max_mem_compaction_level’; did you mean ‘max_compaction_bytes’?
30366 |   __pyx_t_1 = __Pyx_PyInt_From_int(__pyx_v_self->copts->max_mem_compaction_level); if (unlikely(!__pyx_t_1)) __PYX_ERR(0, 1026, __pyx_L1_error)
      |                                                         ^~~~~~~~~~~~~~~~~~~~~~~~
      |                                                         max_compaction_bytes
src/aimrocks/lib_rocksdb.cpp: In function ‘int __pyx_pf_8aimrocks_11lib_rocksdb_19ColumnFamilyOptions_24max_mem_compaction_level_2__set__(__pyx_obj_8aimrocks_11lib_rocksdb_ColumnFamilyOptions*, PyObject*)’:
src/aimrocks/lib_rocksdb.cpp:30429:24: error: ‘struct rocksdb::ColumnFamilyOptions’ has no member named ‘max_mem_compaction_level’; did you mean ‘max_compaction_bytes’?
30429 |   __pyx_v_self->copts->max_mem_compaction_level = __pyx_t_1;
      |                        ^~~~~~~~~~~~~~~~~~~~~~~~
      |                        max_compaction_bytes
src/aimrocks/lib_rocksdb.cpp: In function ‘int __pyx_pymod_exec_lib_rocksdb(PyObject*)’:
src/aimrocks/lib_rocksdb.cpp:81787:21: warning: ‘void PyEval_InitThreads()’ is deprecated [8;;https://gcc.gnu.org/onlinedocs/gcc-14.2.0/gcc/Warning-Options.html#index-Wdeprecated-declarations-Wdeprecated-declarations8;;]
81787 |   PyEval_InitThreads();
      |   ~~~~~~~~~~~~~~~~~~^~
In file included from /nix/store/ic0fd07z8wg57idmw7q7iy7dc7md6x72-python3-3.12.9/include/python3.12/Python.h:95,
                 from src/aimrocks/lib_rocksdb.cpp:78:
/nix/store/ic0fd07z8wg57idmw7q7iy7dc7md6x72-python3-3.12.9/include/python3.12/ceval.h:132:37: note: declared here
  132 | Py_DEPRECATED(3.9) PyAPI_FUNC(void) PyEval_InitThreads(void);
      |                                     ^~~~~~~~~~~~~~~~~~
error: command '/nix/store/rpxlridr3yn6mbmd34r0bya9qv91b79s-gcc-wrapper-14.2.1.20250322/bin/g++' failed with exit code 1