Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make code managable #13

Open
szepeviktor opened this issue Aug 26, 2022 · 4 comments
Open

Make code managable #13

szepeviktor opened this issue Aug 26, 2022 · 4 comments

Comments

@szepeviktor
Copy link

szepeviktor commented Aug 26, 2022 •
edited
Loading

Hello!

Were you thinking about splitting up the Map class into traits the way methods are categorized in README?
Thank you!
@aimeos
Copy link
Owner

aimeos commented Aug 26, 2022 •
edited
Loading

Yes, traits might be a good idea to spit the code into several files

@szepeviktor
Copy link
Author

Proposal for remaining parts.

  • properties
  • constructor
  • implementation methods for \ArrayAccess, \Countable, \IteratorAggregate, \JsonSerializable
  • protected functions

@aimeos
Copy link
Owner

aimeos commented Aug 26, 2022

Dividing the source code like that looks reasonable.
Can you create a PR that splits the code like that?

@szepeviktor
Copy link
Author

No, I'm sorry. I work with code very slowly 🐌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@szepeviktor @aimeos