Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Python 3.9 support #237

Closed
fedebotu opened this issue Jan 14, 2025 · 3 comments
Closed

Drop Python 3.9 support #237

fedebotu opened this issue Jan 14, 2025 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@fedebotu
Copy link
Member

fedebotu commented Jan 14, 2025

Happy New Year, everyone!

Time for some improvement~ Following #236 from @hyeok9855 , I realized that keeping support for Python 3.9 may be annoying. Several recent libraries support from Python 3.10 onwards, such as PyVRP (see here) and the GFlowNet library (see here). Also, with Python >= 3.10 we will be able to:

  • replace Optional[int] by int | None
  • replace Union[int, list] by int | list
  • use match/case

What do you think @cbhua @LTluttmann ? This would also fix our issues in the GFACS @hyeok9855

@fedebotu fedebotu added the enhancement New feature or request label Jan 14, 2025
@fedebotu fedebotu self-assigned this Jan 14, 2025
fedebotu added a commit to hyeok9855/rl4co that referenced this issue Jan 14, 2025
@cbhua
Copy link
Member

cbhua commented Jan 14, 2025

Happy new year mates! Time to back to work.

Based on the status of the Python version, Python 3.9 will end the supporting on 2025.10. Even though I think there are quite a few users who still hold Python 3.9, RL4CO is a package with up-to-date model/environment features for mostly research (in the current state). Also based on my experience, from Python 3.10, the compatibility of Python to the previous version has been improved a lot. Generally for me it would be fine to end the supporting for Python 3.9 at the current time.

@fedebotu
Copy link
Member Author

Happy new year mates! Time to back to work.

Based on the status of the Python version, Python 3.9 will end the supporting on 2025.10. Even though I think there are quite a few users who still hold Python 3.9, RL4CO is a package with up-to-date model/environment features for mostly research (in the current state). Also based on my experience, from Python 3.10, the compatibility of Python to the previous version has been improved a lot. Generally for me it would be fine to end the supporting for Python 3.9 at the current time.

Great! Exactly, since we are in the research domain, I think it is safe to assume upgrading Python versions wouldn't be an issue. According to pypistats the number of installs (at least directly from PyPi) for 3.9 has been pretty low:

image

@cbhua
Copy link
Member

cbhua commented Jan 14, 2025

Wow, this is a really cool statistic plot! Love it. Then it wouldn't hurt that much to drop the support of Python 3.9. But let's write a notification in the Slack channel 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants