feat: add grep-270 for automatic support for MNNVL #273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julien Mancuso <[email protected]>
julienmancuso
requested review from
sanjaychatterjee and
unmarshall
as code owners
Signed-off-by: Julien Mancuso <[email protected]>
gflarity
requested changes
Dec 1, 2025
Contributor
There was a problem hiding this comment.
Thanks @julienmancuso!
IMO we should keep the operator focused on Gang Scheduling, Termination and Rolling Updates. It's already very complicated and I'd recommend not adding any additional complexity here.
That said, I'm confident we can achieve the same goals using optionally installable webhooks ( on PodCliques and PodGangs). All we'd need to do is pass on information around what level (PCS, PCSG or PCLQ) via annotations we'd like the compute domains set at. IMO this would be a bit more cloud-native keeping the operator itself focused on what it already does well.
If you have access to a NVL cluster, I'm pretty sure we can bang out a prototype pretty quickly and validate this. Ping me :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind documentation
GREP for #270