Skip to content

Commit e65419f

Browse files
committed
Remove all response converter, just use output of JSON backend
1 parent 1c76bbf commit e65419f

23 files changed

+16
-2910
lines changed

agda-language-server.cabal

Lines changed: 3 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -48,25 +48,12 @@ flag Agda-2-8-0
4848
library
4949
exposed-modules:
5050
Agda
51-
Agda.Convert
5251
Agda.IR
5352
Agda.Parser
5453
Agda.Position
5554
Control.Concurrent.SizedChan
5655
Monad
5756
Options
58-
Render
59-
Render.Class
60-
Render.Common
61-
Render.Concrete
62-
Render.Interaction
63-
Render.Internal
64-
Render.Literal
65-
Render.Name
66-
Render.Position
67-
Render.RichText
68-
Render.TypeChecking
69-
Render.Utils
7057
Server
7158
Server.CommandController
7259
Server.Handler
@@ -81,7 +68,7 @@ library
8168
OverloadedStrings
8269
PatternSynonyms
8370
TypeOperators
84-
ghc-options: -Wincomplete-patterns -Wunused-do-bind -Wunused-foralls -Wwarnings-deprecations -Wwrong-do-bind -Wmissing-fields -Wmissing-methods -Wmissing-pattern-synonym-signatures -Wmissing-signatures -Werror=incomplete-patterns -fno-warn-orphans
71+
ghc-options: -Wincomplete-patterns -Wunused-do-bind -Wunused-foralls -Wwarnings-deprecations -Wwrong-do-bind -Wmissing-fields -Wmissing-methods -Wmissing-pattern-synonym-signatures -Wmissing-signatures -Werror=incomplete-patterns -fno-warn-orphans -Wunused-imports -fsplit-sections
8572
build-depends:
8673
Agda
8774
, aeson
@@ -127,7 +114,7 @@ executable als
127114
OverloadedStrings
128115
PatternSynonyms
129116
TypeOperators
130-
ghc-options: -Wincomplete-patterns -Wunused-do-bind -Wunused-foralls -Wwarnings-deprecations -Wwrong-do-bind -Wmissing-fields -Wmissing-methods -Wmissing-pattern-synonym-signatures -Wmissing-signatures -rtsopts -Werror=incomplete-patterns -fno-warn-orphans
117+
ghc-options: -Wincomplete-patterns -Wunused-do-bind -Wunused-foralls -Wwarnings-deprecations -Wwrong-do-bind -Wmissing-fields -Wmissing-methods -Wmissing-pattern-synonym-signatures -Wmissing-signatures -rtsopts -Werror=incomplete-patterns -fno-warn-orphans -Wunused-imports -fsplit-sections
131118
build-depends:
132119
Agda
133120
, aeson
@@ -172,25 +159,12 @@ test-suite als-test
172159
Test.SrcLoc
173160
Test.WASM
174161
Agda
175-
Agda.Convert
176162
Agda.IR
177163
Agda.Parser
178164
Agda.Position
179165
Control.Concurrent.SizedChan
180166
Monad
181167
Options
182-
Render
183-
Render.Class
184-
Render.Common
185-
Render.Concrete
186-
Render.Interaction
187-
Render.Internal
188-
Render.Literal
189-
Render.Name
190-
Render.Position
191-
Render.RichText
192-
Render.TypeChecking
193-
Render.Utils
194168
Server
195169
Server.CommandController
196170
Server.Handler
@@ -205,7 +179,7 @@ test-suite als-test
205179
OverloadedStrings
206180
PatternSynonyms
207181
TypeOperators
208-
ghc-options: -Wincomplete-patterns -Wunused-do-bind -Wunused-foralls -Wwarnings-deprecations -Wwrong-do-bind -Wmissing-fields -Wmissing-methods -Wmissing-pattern-synonym-signatures -Wmissing-signatures -rtsopts -Werror=incomplete-patterns -fno-warn-orphans
182+
ghc-options: -Wincomplete-patterns -Wunused-do-bind -Wunused-foralls -Wwarnings-deprecations -Wwrong-do-bind -Wmissing-fields -Wmissing-methods -Wmissing-pattern-synonym-signatures -Wmissing-signatures -rtsopts -Werror=incomplete-patterns -fno-warn-orphans -Wunused-imports -fsplit-sections
209183
build-depends:
210184
Agda
211185
, aeson

app/Main.hs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,10 @@ import Control.Monad (when)
55
import Options
66
import Server (run)
77
-- import Simple (run)
8-
import System.Console.GetOpt
98
import System.Directory (doesDirectoryExist)
109
import System.Environment
1110
import System.FilePath ((</>))
1211
import System.IO
13-
import Text.Read (readMaybe)
1412

1513
#if MIN_VERSION_Agda(2,8,0)
1614
import Agda.Setup (setup)

hie.yaml

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,2 @@
11
cradle:
2-
stack:
3-
- path: "./src"
4-
component: "agda-language-server:lib"
5-
6-
- path: "./app/Main.hs"
7-
component: "agda-language-server:exe:als"
8-
9-
- path: "./app/Paths_agda_language_server.hs"
10-
component: "agda-language-server:exe:als"
11-
12-
- path: "./test"
13-
component: "agda-language-server:test:als-test"
2+
cabal:

src/Agda.hs

Lines changed: 4 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -16,15 +16,13 @@ import Prelude hiding ( null )
1616

1717
import Agda.Compiler.Backend ( parseBackendOptions )
1818
import Agda.Compiler.Builtin ( builtinBackends )
19-
import Agda.Convert ( fromResponse )
2019
import Agda.Interaction.Base ( Command
2120
, Command'(Command, Done, Error)
2221
#if MIN_VERSION_Agda(2,7,0)
2322
#else
2423
, CommandM
2524
#endif
2625
, CommandState(optionsOnReload)
27-
, IOTCM
2826
, initCommandState
2927
, parseIOTCM
3028
)
@@ -61,7 +59,6 @@ import Agda.TypeChecking.Monad.Base ( TCM )
6159
import qualified Agda.TypeChecking.Monad.Benchmark
6260
as Bench
6361
import Agda.TypeChecking.Monad.State ( setInteractionOutputCallback )
64-
import Agda.Utils.FileName ( absolute )
6562
import Agda.Utils.Impossible ( CatchImpossible
6663
( catchImpossible
6764
)
@@ -82,18 +79,16 @@ import Data.Aeson ( FromJSON
8279
, fromJSON
8380
)
8481
import qualified Data.Aeson as JSON
85-
import Data.Maybe ( listToMaybe )
8682
import Data.Text ( pack )
8783
import GHC.Generics ( Generic )
88-
import Language.LSP.Server ( getConfig )
8984
import Monad
9085
import Options ( Config(configRawAgdaOptions)
91-
, Options(optRawAgdaOptions, optRawResponses)
86+
, Options(optRawAgdaOptions)
9287
, versionNumber
9388
)
9489

9590
import qualified Agda.IR as IR
96-
import Agda.Interaction.JSON ( encode, encodeTCM )
91+
import Agda.Interaction.JSON ( encodeTCM )
9792
import Agda.Interaction.JSONTop ()
9893

9994
getAgdaVersion :: String
@@ -108,13 +103,8 @@ start = do
108103
result <- runAgda $ do
109104
-- decides how to output Response
110105
lift $ setInteractionOutputCallback $ \response -> do
111-
resp <- if optRawResponses (envOptions env)
112-
then do
113-
value <- (pure . encodeTCM) response
114-
resp' <- fmap IR.ResponseJSONRaw value
115-
return resp'
116-
else fromResponse response
117-
106+
value <- (pure . encodeTCM) response
107+
resp <- fmap IR.ResponseJSONRaw value
118108
sendResponse env resp
119109

120110
-- keep reading command

0 commit comments

Comments
 (0)