Skip to content

Commit f849cc7

Browse files
committed
add pragma for tautological compare for cleaner clang compiles.
1 parent 97a26fe commit f849cc7

File tree

1 file changed

+9
-0
lines changed

1 file changed

+9
-0
lines changed

sbe-tool/src/main/java/uk/co/real_logic/sbe/generation/cpp/CppGenerator.java

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -375,7 +375,10 @@ private static CharSequence generateGroupProperty(
375375
indent + " }\n\n" +
376376
indent + " bool %1$sInActingVersion(void)\n" +
377377
indent + " {\n" +
378+
indent + "#pragma GCC diagnostic push\n" +
379+
indent + "#pragma GCC diagnostic ignored \"-Wtautological-compare\"\n" +
378380
indent + " return m_actingVersion >= %1$sSinceVersion();\n" +
381+
indent + "#pragma GCC diagnostic pop\n" +
379382
indent + " }\n",
380383
propertyName,
381384
(long)token.version()));
@@ -537,7 +540,10 @@ private void generateVarDataDescriptors(
537540
indent + " }\n\n" +
538541
indent + " bool %1$sInActingVersion(void)\n" +
539542
indent + " {\n" +
543+
indent + "#pragma GCC diagnostic push\n" +
544+
indent + "#pragma GCC diagnostic ignored \"-Wtautological-compare\"\n" +
540545
indent + " return m_actingVersion >= %1$sSinceVersion();\n" +
546+
indent + "#pragma GCC diagnostic pop\n" +
541547
indent + " }\n\n" +
542548
indent + " static SBE_CONSTEXPR const std::uint16_t %1$sId(void)\n" +
543549
indent + " {\n" +
@@ -1473,7 +1479,10 @@ private CharSequence generateFields(final String containingClassName, final List
14731479
indent + " }\n\n" +
14741480
indent + " bool %1$sInActingVersion(void)\n" +
14751481
indent + " {\n" +
1482+
indent + "#pragma GCC diagnostic push\n" +
1483+
indent + "#pragma GCC diagnostic ignored \"-Wtautological-compare\"\n" +
14761484
indent + " return m_actingVersion >= %1$sSinceVersion();\n" +
1485+
indent + "#pragma GCC diagnostic pop\n" +
14771486
indent + " }\n\n",
14781487
propertyName,
14791488
(long)signalToken.version()));

0 commit comments

Comments
 (0)