Skip to content

Commit 4e1e52d

Browse files
committed
naming consistency: getter has no 'get' prefix, so remove the 'put' prefix in encoder.
1 parent b4543d5 commit 4e1e52d

File tree

3 files changed

+5
-12
lines changed

3 files changed

+5
-12
lines changed

sbe-tool/src/main/java/uk/co/real_logic/sbe/generation/java/JavaGenerator.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1714,7 +1714,7 @@ private CharSequence generatePrimitiveArrayPropertyEncode(
17141714
offset));
17151715

17161716
sb.append(String.format(
1717-
indent + " public %s put%s(final String src)\n" +
1717+
indent + " public %s %s(final String src)\n" +
17181718
indent + " {\n" +
17191719
indent + " final int length = %d;\n" +
17201720
indent + " final byte[] bytes = src.getBytes(%s);\n" +
@@ -1731,7 +1731,7 @@ private CharSequence generatePrimitiveArrayPropertyEncode(
17311731
indent + " return this;\n" +
17321732
indent + " }\n",
17331733
formatClassName(containingClassName),
1734-
toUpperFirstChar(propertyName),
1734+
propertyName,
17351735
fieldLength,
17361736
charset(encoding.characterEncoding()),
17371737
offset,

sbe-tool/src/test/java/uk/co/real_logic/sbe/generation/java/JavaGeneratorTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -360,13 +360,13 @@ public void shouldGenerateGetString() throws Exception
360360
final Object encoder = wrap(buffer, compileCarEncoder().newInstance());
361361
final Object decoder = getCarDecoder(buffer, encoder);
362362

363-
putString(encoder, "vehicleCode", "R11");
363+
set(encoder, "vehicleCode", String.class, "R11");
364364
assertThat(get(decoder, "vehicleCode"), is("R11"));
365365

366-
putString(encoder, "vehicleCode", "");
366+
set(encoder, "vehicleCode", String.class, "");
367367
assertThat(get(decoder, "vehicleCode"), is(""));
368368

369-
putString(encoder, "vehicleCode", "R11R12");
369+
set(encoder, "vehicleCode", String.class, "R11R12");
370370
assertThat(get(decoder, "vehicleCode"), is("R11R12"));
371371
}
372372

sbe-tool/src/test/java/uk/co/real_logic/sbe/generation/java/ReflectionUtil.java

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,6 @@
1515
*/
1616
package uk.co.real_logic.sbe.generation.java;
1717

18-
import static uk.co.real_logic.sbe.generation.java.JavaUtil.toUpperFirstChar;
19-
2018
public final class ReflectionUtil
2119
{
2220
static int getSbeSchemaVersion(final Object encoder) throws Exception
@@ -124,9 +122,4 @@ static int getCount(Object groupFlyweight) throws Exception
124122
{
125123
return getInt(groupFlyweight, "count");
126124
}
127-
128-
static void putString(Object object, String name, String value) throws Exception
129-
{
130-
object.getClass().getMethod("put" + toUpperFirstChar(name), String.class).invoke(object, value);
131-
}
132125
}

0 commit comments

Comments
 (0)