Skip to content

Commit f5b2b9a

Browse files
committed
Fix types en linting
1 parent 5680d0a commit f5b2b9a

File tree

5 files changed

+22
-20
lines changed

5 files changed

+22
-20
lines changed

pyproject.toml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,6 @@
11
[tool.black]
22
target-version = ["py34", "py35", "py36", "py37", "py38"]
3+
4+
[tool.pyright]
5+
venvPath = "."
6+
venv = ".tox/py311"

rflink/__main__.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,9 @@
2323
import asyncio
2424
import logging
2525
import sys
26+
from importlib.metadata import version
2627
from typing import Dict, Optional, Sequence, Type # noqa: unused-import
2728

28-
import pkg_resources
2929
from docopt import docopt
3030

3131
from .protocol import ( # noqa: unused-import
@@ -54,9 +54,7 @@ def main(
5454
argv: Sequence[str] = sys.argv[1:], loop: Optional[asyncio.AbstractEventLoop] = None
5555
) -> None:
5656
"""Parse argument and setup main program loop."""
57-
args = docopt(
58-
__doc__, argv=argv, version=pkg_resources.require("rflink")[0].version
59-
)
57+
args = docopt(__doc__, argv=argv, version=version("rflink"))
6058

6159
level = logging.ERROR
6260
if args["-v"]:

rflink/protocol.py

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -6,25 +6,22 @@
66
import asyncio
77
import concurrent
88
import logging
9+
import socket
910
from datetime import timedelta
1011
from fnmatch import fnmatchcase
1112
from functools import partial
1213
from typing import (
1314
TYPE_CHECKING,
1415
Any,
1516
Callable,
16-
Generator,
1717
Optional,
1818
Sequence,
19-
Tuple,
2019
Type,
2120
Union,
2221
cast,
2322
overload,
2423
)
2524

26-
import socket
27-
2825
from serial_asyncio_fast import create_serial_connection
2926

3027
from .parser import (
@@ -394,7 +391,7 @@ def create_rflink_connection(
394391
disconnect_callback: Optional[Callable[[Optional[Exception]], None]] = None,
395392
ignore: Optional[Sequence[str]] = None,
396393
loop: Optional[asyncio.AbstractEventLoop] = None,
397-
) -> "Coroutine[Any, Any, Tuple[asyncio.BaseTransport, ProtocolBase]]":
394+
) -> "Coroutine[Any, Any, tuple[asyncio.Transport, asyncio.Protocol]]":
398395
"""Create Rflink manager class, returns transport coroutine."""
399396
...
400397

@@ -411,7 +408,7 @@ def create_rflink_connection(
411408
disconnect_callback: Optional[Callable[[Optional[Exception]], None]] = None,
412409
ignore: Optional[Sequence[str]] = None,
413410
loop: Optional[asyncio.AbstractEventLoop] = None,
414-
) -> "Coroutine[Any, Any, Tuple[asyncio.BaseTransport, ProtocolBase]]":
411+
) -> "Coroutine[Any, Any, tuple[asyncio.Transport, asyncio.Protocol]]":
415412
"""Create Rflink manager class, returns transport coroutine."""
416413
...
417414

@@ -427,7 +424,7 @@ def create_rflink_connection(
427424
disconnect_callback: Optional[Callable[[Optional[Exception]], None]] = None,
428425
ignore: Optional[Sequence[str]] = None,
429426
loop: Optional[asyncio.AbstractEventLoop] = None,
430-
) -> "Coroutine[Any, Any, Tuple[asyncio.BaseTransport, ProtocolBase]]":
427+
) -> "Coroutine[Any, Any, tuple[asyncio.Transport, asyncio.Protocol]]":
431428
"""Create Rflink manager class, returns transport coroutine."""
432429
if loop is None:
433430
loop = asyncio.get_event_loop()
@@ -442,10 +439,12 @@ def create_rflink_connection(
442439
keepalive=keepalive,
443440
)
444441

442+
conn: Coroutine[Any, Any, tuple[asyncio.Transport, asyncio.Protocol]]
443+
445444
# setup serial connection if no transport specified
446445
if host:
447446
conn = loop.create_connection(protocol_factory, host, cast(int, port))
448447
else:
449-
conn = create_serial_connection(loop, protocol_factory, port, baud)
448+
conn = create_serial_connection(loop, protocol_factory, str(port), baud)
450449

451-
return conn # type: ignore
450+
return conn

rflinkproxy/__main__.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,9 @@
2121
import logging
2222
import sys
2323
from functools import partial
24+
from importlib.metadata import version
2425
from typing import Any, Callable, Dict, cast
2526

26-
import pkg_resources
2727
from docopt import docopt
2828
from serial_asyncio_fast import create_serial_connection
2929

@@ -279,9 +279,7 @@ async def connect(self):
279279

280280
def main(argv=sys.argv[1:], loop=None):
281281
"""Parse argument and setup main program loop."""
282-
args = docopt(
283-
__doc__, argv=argv, version=pkg_resources.require("rflink")[0].version
284-
)
282+
args = docopt(__doc__, argv=argv, version=version("rflink"))
285283

286284
level = logging.ERROR
287285
if args["-v"]:

tox.ini

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ usedevelop = True
2424
[testenv:fix]
2525
commands =
2626
autopep8 --aggressive --in-place --recursive .
27-
isort -rc .
27+
isort .
2828
black .
2929
deps =
3030
isort
@@ -43,8 +43,11 @@ deps =
4343
pyflakes<2.5
4444

4545
[testenv:typing]
46-
commands = mypy --strict --ignore-missing-imports rflink
47-
deps = mypy
46+
commands = mypy --install-types --non-interactive --strict --follow-untyped-imports --ignore-missing-imports rflink
47+
#commands = basedpyright rflink
48+
deps =
49+
types-docopt
50+
mypy
4851

4952
[testenv:pypy3]
5053
deps =

0 commit comments

Comments
 (0)