Refactor exclusion for readability

knewbury01 · knewbury01 · commit f286b5faee25 · 2024-07-22T19:38:40.000-04:00
diff --git a/javascript/frameworks/cap/lib/advanced_security/javascript/frameworks/cap/CAPLogInjectionQuery.qll b/javascript/frameworks/cap/lib/advanced_security/javascript/frameworks/cap/CAPLogInjectionQuery.qll
@@ -37,7 +37,7 @@ class CdsLogSink extends DataFlow::Node {
       this = loggingMethod.getAnArgument() and
       loggingMethod.getMethodName() = ["trace", "debug", "info", "log", "warn", "error"] and
       not this.asExpr() instanceof Literal and
-      not exists(ConstantOnlyTemplateLiteral t | this.asExpr() = t) and
+      not this.asExpr() instanceof ConstantOnlyTemplateLiteral and
       loggingMethod.getReceiver().getALocalSource() = log
     )
   }

Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@ class CdsLogSink extends DataFlow::Node {`
`37`	`37`	`this = loggingMethod.getAnArgument() and`
`38`	`38`	`loggingMethod.getMethodName() = ["trace", "debug", "info", "log", "warn", "error"] and`
`39`	`39`	`not this.asExpr() instanceof Literal and`
`40`		`- not exists(ConstantOnlyTemplateLiteral t \| this.asExpr() = t) and`
	`40`	`+ not this.asExpr() instanceof ConstantOnlyTemplateLiteral and`
`41`	`41`	`loggingMethod.getReceiver().getALocalSource() = log`
`42`	`42`	`)`
`43`	`43`	`}`