Skip to content

Commit cab928d

Browse files
committed
Remove the overriding characteristic predicates
1 parent c4eb9a4 commit cab928d

File tree

6 files changed

+4
-12
lines changed

6 files changed

+4
-12
lines changed

javascript/frameworks/cap/lib/advanced_security/javascript/frameworks/cap/CAPLogInjectionQuery.qll

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,6 @@ class CdsLogSink extends DataFlow::Node {
4444
}
4545

4646
class CAPLogInjectionConfiguration extends LogInjectionConfiguration {
47-
CAPLogInjectionConfiguration() { this = "CAP Log Injection" }
48-
4947
override predicate isSource(DataFlow::Node start) {
5048
super.isSource(start)
5149
or

javascript/frameworks/ui5/lib/advanced_security/javascript/frameworks/ui5/UI5XssQuery.qll

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@ import advanced_security.javascript.frameworks.ui5.UI5View
44
import semmle.javascript.security.dataflow.DomBasedXssQuery as DomBasedXss
55

66
class Configuration extends DomBasedXss::Configuration {
7-
Configuration() { this = "UI5 HTML Injection" }
8-
97
override predicate isSource(DataFlow::Node start) {
108
super.isSource(start)
119
or

javascript/frameworks/ui5/test/queries/UI5Xss/avoid-duplicate-alerts/UI5Xss.expected

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ nodes
1212
| XssTest.js:18:9:18:44 | value1 |
1313
| XssTest.js:18:18:18:44 | jQuery. ... (value) |
1414
| XssTest.js:18:39:18:43 | value |
15+
| XssTest.js:19:20:19:25 | value1 |
1516
| XssTest.js:20:27:20:32 | value1 |
1617
edges
1718
| XssTest.js:3:9:3:50 | value | XssTest.js:4:20:4:24 | value |
@@ -22,6 +23,7 @@ edges
2223
| XssTest.js:10:17:10:40 | documen ... .search | XssTest.js:10:9:10:40 | value |
2324
| XssTest.js:17:9:17:40 | value | XssTest.js:18:39:18:43 | value |
2425
| XssTest.js:17:17:17:40 | documen ... .search | XssTest.js:17:9:17:40 | value |
26+
| XssTest.js:18:9:18:44 | value1 | XssTest.js:19:20:19:25 | value1 |
2527
| XssTest.js:18:9:18:44 | value1 | XssTest.js:20:27:20:32 | value1 |
2628
| XssTest.js:18:18:18:44 | jQuery. ... (value) | XssTest.js:18:9:18:44 | value1 |
2729
| XssTest.js:18:39:18:43 | value | XssTest.js:18:18:18:44 | jQuery. ... (value) |

javascript/frameworks/xsjs/lib/advanced_security/javascript/frameworks/xsjs/XSJSReflectedXssQuery.qll

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import javascript
22
import advanced_security.javascript.frameworks.xsjs.AsyncXSJS
3-
import semmle.javascript.security.dataflow.DomBasedXssQuery as DomBasedXss
3+
import semmle.javascript.security.dataflow.ReflectedXssQuery as ReflectedXssQuery
44

55
class XSJSResponseSetBodyCall extends MethodCallNode {
66
XSJSResponse response;
@@ -13,9 +13,7 @@ class XSJSResponseSetBodyCall extends MethodCallNode {
1313
XSJSResponse getParentXSJSResponse() { result = response }
1414
}
1515

16-
class Configuration extends DomBasedXss::Configuration {
17-
Configuration() { this = "XSJS Reflected XSS Query" }
18-
16+
class Configuration extends ReflectedXssQuery::Configuration {
1917
override predicate isSource(DataFlow::Node start) {
2018
super.isSource(start) or
2119
start instanceof RemoteFlowSource

javascript/frameworks/xsjs/lib/advanced_security/javascript/frameworks/xsjs/XSJSSqlInjectionQuery.qll

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,6 @@ class XSJSDBConnectionPrepareStatementArgument extends DataFlow::ValueNode {
1313
}
1414

1515
class Configuration extends SqlInjection::Configuration {
16-
Configuration() { this = "XSJS SQL Injection Query" }
17-
1816
override predicate isSource(DataFlow::Node start) {
1917
super.isSource(start)
2018
or

javascript/frameworks/xsjs/lib/advanced_security/javascript/frameworks/xsjs/XSJSUrlRedirectQuery.qll

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,6 @@ import advanced_security.javascript.frameworks.xsjs.AsyncXSJS
33
import semmle.javascript.security.dataflow.ServerSideUrlRedirectQuery as UrlRedirect
44

55
class Configuration extends UrlRedirect::Configuration {
6-
Configuration() { this = "XSJS URL Redirect Query" }
7-
86
override predicate isSource(DataFlow::Node start) {
97
super.isSource(start)
108
or

0 commit comments

Comments
 (0)