Skip to content

[Bug]: sp-button mod tokens blocked #5352

Open
@SavkaTaras

Description

@SavkaTaras

Code of conduct

  • I agree to follow this project's code of conduct.

Impacted component(s)

sp-button

Expected behavior

To be able to use any --mod-* css tokens to override needed properties.

Actual behavior

packages/button/src/button-overrides.css uses --mod-* tokens instead of --spectrum-* to override different variants of the button. Please see required patch to fix the issue:
7a47013
please note there is a typo for --mspectrumod-button-background-color-down, which should be --spectrum-button-background-color-down

Screenshots

Image

What browsers are you seeing the problem in?

No response

How can we reproduce this issue?

  1. Go to https://opensource.adobe.com/spectrum-web-components/storybook/index.html?path=/story/button-group-sizes--m

Sample code or abstract reproduction which illustrates the problem

No response

Severity

SEV 1

Logs taken while reproducing problem

No response

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions