Allow Modal to pass a dismiss label prop to DismissButton to override the default

[lukpsaxo]

Provide a general summary of the feature here

In Modal -
https://github.com/adobe/react-spectrum/blob/main/packages/react-aria-components/src/Modal.tsx#L217

There is no way to pass a dismiss label to override the default. It is already supported by DismissButton.

💁 Possible Solution

Would you want Modal to take dismiss-aria-label ? I suppose aria-label on a Modal shouldn't be the text to dismiss?

🔦 Context

We have multiple ways to cancel/dismiss a dialog and for accessibility reasons I'd like them to have the same label. We also support some language variants you don't.

💻 Examples

No response

🧢 Your Company/Team

Saxo Bank

🕷 Tracking Issue

No response

[lukpsaxo]

Happy to make a PR if I get some guidance on what it should look like.

[snowystinger]

Linking relevant issues for internal discussion
Injecting translations to react-aria
#7257
#2999 (reply in thread)

[lukpsaxo]

The translations support you linked to would be great, but we may still want to have a dismiss text per dialog in order to match the text with the dialogs cancel button, so for us we would prefer a prop to allow passing a string in.

@devongovett's suggestion in the thread to pass messages would kind-of work for us - we would end up passing messages={{ [currentLanguage]: internalGetTranslatedText() }}

Is that something you would accept pr's on?