-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add renderProp support for if a Table row has visible focus within it #6350
Conversation
useful for making a row style that remains applied when anything in the table row is focused, not just the row itself
This reverts commit 1aacf8f.
Can be linked to: #5258 (my initial issue was to support it across whole RAC, but only needed it in the Row, which this PR seems to add 🙏 ) |
@jaknas thanks for the issue link (may have slipped my mind to see if anyone filed a issue for this change when making the PR 😅). I'm still evaluating what other elements should also expose some version of isFocusVisibleWithin as I work on styling an adjacent component that uses RAC table but can definitely get this merged in for now so a nightly can built. Do you also need info for |
this is for s2, make keyboard skip the resizer via data-react-aria-prevent-focus
I can't say for sure without testing. |
@jaknas gotcha, I'll see about getting this merged in early then so we can get a nightly out for testing. |
## API Changes
unknown top level export { type: 'any' } |
Closes #5258
useful for making a row style that remains applied when anything in the table row is focused, not just the row itself (e.g. make the whole row blue when a cell inside is keyboard focused). Needed for S2.
Other changes to come as I run into them while working on S2
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project:
RSP