ListView Drag and Drop "link" behavior using Ctrl or Alt as modifier key does not work with keyboard

[majornista]

🐛 Bug Report

Using the ListView Drag and Drop -- draggable rows allow copy and link Storybook Story, after selecting an item to drag using the keyboard and moving keyboard focus the drop target, try to drop as a link using Alt+Enter on Windows/Control+Enter on macOS keyboard combination.

🤔 Expected Behavior

Drag and Drop should fire events to complete a dropOperation: "link" on the drop target onDrop, dragEnd, onDropExit.

😯 Current Behavior

Drag and Drop only allows copy or cancel drop operations, Alt+Enter triggers the DragSession.activate() method, while Ctrl+Enter triggers a copy drop operation rather than a link.

💁 Possible Solution

We need to determine the allowed drop operations when the Enter key is pressed using a modifier on a drop target, here:

react-spectrum/packages/@react-aria/dnd/src/DragManager.ts

Lines 217 to 248 in e044ef7

	onKeyDown(e: KeyboardEvent) {
	this.cancelEvent(e);
	if (e.key === 'Escape') {
	this.cancel();
	return;
	}
	if (e.key === 'Tab' && !(e.metaKey || e.altKey || e.ctrlKey)) {
	if (e.shiftKey) {
	this.previous();
	} else {
	this.next();
	}
	}
	if (typeof this.currentDropTarget?.onKeyDown === 'function') {
	this.currentDropTarget.onKeyDown(e, this.dragTarget);
	}
	}
	onKeyUp(e: KeyboardEvent) {
	this.cancelEvent(e);
	if (e.key === 'Enter') {
	if (e.altKey) {
	this.activate();
	} else {
	this.drop();
	}
	}
	}

🔦 Context

FY23 Accessibility Audit

💻 Code Sample

🌍 Your Environment

Software	Version(s)
react-spectrum	@adobe/react-spectrum@3.25.1
Browser	Chrome Version 111.0.5563.64 (Official Build) (arm64)
Operating System	macOS Ventura 13.2.1 (22D68)

🧢 Your Company/Team

🕷 Tracking Issue (optional)

[devongovett]

I believe this was "by design" to some extent. We support these modifier keys where they are supported by the operating system native drag and drop api, but even between desktop browsers and OS'es support differs. iOS and Android also don't support them with touch. So I think we considered this an optional feature that we'd support if the OS provided it but not beyond that.

[majornista]

I believe this was "by design" to some extent. We support these modifier keys where they are supported by the operating system native drag and drop api, but even between desktop browsers and OS'es support differs. iOS and Android also don't support them with touch. So I think we considered this an optional feature that we'd support if the OS provided it but not beyond that.

Makes sense, but as I suggest, we could possibly support it if we determine the allowed drop operations when the keyboard event to drop triggers on the drop target, and not just in the onDragOver event when dragging.

[devongovett]

Sure but it still wouldn't work on touch or with mobile screen readers so I wonder how much benefit it would add. We also might eventually want to use the modifier keys for other things, like drag activation (equivalent for dragging and holding over a folder for example).