usePress does not call pointer/mouse events

[ivanbanov]

When using usePress pointers and mouse events dont call the passed callbacks 😞
It seems like we was decided to do not fire it only for pointers, not keyboard.

Im using the following workaround
https://codesandbox.io/s/happy-maxwell-yie18q?file=/src/App.js

import React, { useRef } from "react";
import { useButton } from "react-aria";

const BROKEN_PRESS_EVENTS = [
  "onMouseDown",
  "onMouseUp",
  "onPointerDown",
  "onPointerUp"
];

const Button = React.forwardRef(
  ({ children, disabled, onPress, ...props }, forwardRef) => {
    const ref = useRef();
    const refWithFallback = forwardRef ?? ref;

    const { buttonProps } = useButton(
      {
        ...props,
        onPress,
        isDisabled: disabled
      },
      refWithFallback
    );

    const fixedButtonProps = Object.entries(buttonProps).reduce(
      (result, [prop, value]) => {
        return {
          ...result,
          [prop]: BROKEN_PRESS_EVENTS.includes(prop)
            ? (e) => {
                props[prop]?.(e);
                value?.(e);
              }
            : value
        };
      },
      {}
    );

    return (
      <>
        <button {...props} {...fixedButtonProps} ref={refWithFallback}>
          {children}
        </button>
      </>
    );
  }
);

export default Button;

Question is, was it intentional? Should I open a PR?

Thanks!

[devongovett]

mergeProps is available for this exact purpose: https://react-spectrum.adobe.com/react-aria/mergeProps.html