Add TS no-redeclare ESLint rule (#2246)

Author: solimant

.eslintrc.js

@@ -35,6 +35,8 @@ module.exports = {
       // enable this rule to see literally everything missing jsdocs, this rule needs some refinement but is good as a sanity check.
       // 'jsdoc/require-jsdoc': [ERROR, {contexts:['TSInterfaceDeclaration TSPropertySignature', 'TSInterfaceDeclaration TSMethodSignature']}],
       'jsdoc/require-description': [ERROR, {exemptedBy: ['deprecated'], checkConstructors: false}],
+      'no-redeclare': OFF,
+      '@typescript-eslint/no-redeclare': ERROR,
       'no-unused-vars': OFF,
       '@typescript-eslint/no-unused-vars': ERROR,
       '@typescript-eslint/member-delimiter-style': [ERROR, {

packages/@internationalized/date/src/manipulation.ts

@@ -19,12 +19,10 @@ import {Mutable} from './utils';
 
 const ONE_HOUR = 3600000;
 
-/* eslint-disable no-redeclare */
 export function add(date: CalendarDateTime, duration: Duration): CalendarDateTime;
 export function add(date: CalendarDate, duration: Duration): CalendarDate;
 export function add(date: CalendarDate | CalendarDateTime, duration: Duration): CalendarDate | CalendarDateTime;
 export function add(date: CalendarDate | CalendarDateTime, duration: Duration) {
-/* eslint-enable no-redeclare */
   let mutableDate: Mutable<AnyCalendarDate> = date.copy();
   let days = 'hour' in date ? addTimeFields(date, duration) : 0;
 
@@ -115,19 +113,15 @@ export function invertDuration(duration: Duration): Duration {
   return inverseDuration;
 }
 
-/* eslint-disable no-redeclare */
 export function subtract(date: CalendarDateTime, duration: Duration): CalendarDateTime;
 export function subtract(date: CalendarDate, duration: Duration): CalendarDate;
 export function subtract(date: CalendarDate | CalendarDateTime, duration: Duration): CalendarDate | CalendarDateTime {
-/* eslint-enable no-redeclare */
   return add(date, invertDuration(duration));
 }
 
-/* eslint-disable no-redeclare */
 export function set(date: CalendarDateTime, fields: DateFields): CalendarDateTime;
 export function set(date: CalendarDate, fields: DateFields): CalendarDate;
 export function set(date: CalendarDate | CalendarDateTime, fields: DateFields) {
-/* eslint-enable no-redeclare */
   let mutableDate: Mutable<AnyCalendarDate> = date.copy();
 
   if (fields.era != null) {
@@ -150,11 +144,9 @@ export function set(date: CalendarDate | CalendarDateTime, fields: DateFields) {
   return mutableDate;
 }
 
-/* eslint-disable no-redeclare */
 export function setTime(value: CalendarDateTime, fields: TimeFields): CalendarDateTime;
 export function setTime(value: Time, fields: TimeFields): Time;
 export function setTime(value: Time | CalendarDateTime, fields: TimeFields) {
-/* eslint-enable no-redeclare */
   let mutableValue: Mutable<Time | CalendarDateTime> = value.copy();
 
   if (fields.hour != null) {
@@ -226,11 +218,9 @@ export function subtractTime(time: Time, duration: Duration): Time {
   return addTime(time, invertDuration(duration));
 }
 
-/* eslint-disable no-redeclare */
 export function cycleDate(value: CalendarDateTime, field: DateField, amount: number, options?: CycleOptions): CalendarDateTime;
 export function cycleDate(value: CalendarDate, field: DateField, amount: number, options?: CycleOptions): CalendarDate;
 export function cycleDate(value: CalendarDate | CalendarDateTime, field: DateField, amount: number, options?: CycleOptions) {
-/* eslint-enable no-redeclare */
   let mutable: Mutable<CalendarDate | CalendarDateTime> = value.copy();
 
   switch (field) {
@@ -262,11 +252,9 @@ export function cycleDate(value: CalendarDate | CalendarDateTime, field: DateFie
   return mutable;
 }
 
-/* eslint-disable no-redeclare */
 export function cycleTime(value: CalendarDateTime, field: TimeField, amount: number, options?: CycleTimeOptions): CalendarDateTime;
 export function cycleTime(value: Time, field: TimeField, amount: number, options?: CycleTimeOptions): Time;
 export function cycleTime(value: Time | CalendarDateTime, field: TimeField, amount: number, options?: CycleTimeOptions) {
-/* eslint-enable no-redeclare */
   let mutable: Mutable<Time | CalendarDateTime> = value.copy();
 
   switch (field) {

packages/@react-aria/button/src/useButton.ts

@@ -32,7 +32,6 @@ export interface ButtonAria<T> {
   isPressed: boolean
 }
 
-/* eslint-disable no-redeclare */
 export function useButton(props: AriaButtonProps<'a'>, ref: RefObject<HTMLAnchorElement>): ButtonAria<AnchorHTMLAttributes<HTMLAnchorElement>>;
 export function useButton(props: AriaButtonProps<'button'>, ref: RefObject<HTMLButtonElement>): ButtonAria<ButtonHTMLAttributes<HTMLButtonElement>>;
 export function useButton(props: AriaButtonProps<'div'>, ref: RefObject<HTMLDivElement>): ButtonAria<HTMLAttributes<HTMLDivElement>>;
@@ -46,7 +45,6 @@ export function useButton(props: AriaButtonProps<ElementType>, ref: RefObject<HT
  * @param ref - A ref to a DOM element for the button.
  */
 export function useButton(props: AriaButtonProps<ElementType>, ref: RefObject<any>): ButtonAria<HTMLAttributes<any>> {
-/* eslint-enable no-redeclare */
   let {
     elementType = 'button',
     isDisabled,

packages/@react-aria/button/src/useToggleButton.ts

@@ -24,7 +24,6 @@ import {chain} from '@react-aria/utils';
 import {mergeProps} from '@react-aria/utils';
 import {ToggleState} from '@react-stately/toggle';
 
-/* eslint-disable no-redeclare */
 export function useToggleButton(props: AriaToggleButtonProps<'a'>, state: ToggleState, ref: RefObject<HTMLAnchorElement>): ButtonAria<AnchorHTMLAttributes<HTMLAnchorElement>>;
 export function useToggleButton(props: AriaToggleButtonProps<'button'>, state: ToggleState, ref: RefObject<HTMLButtonElement>): ButtonAria<ButtonHTMLAttributes<HTMLButtonElement>>;
 export function useToggleButton(props: AriaToggleButtonProps<'div'>, state: ToggleState, ref: RefObject<HTMLDivElement>): ButtonAria<HTMLAttributes<HTMLDivElement>>;
@@ -36,7 +35,6 @@ export function useToggleButton(props: AriaToggleButtonProps<ElementType>, state
  * ToggleButtons allow users to toggle a selection on or off, for example switching between two states or modes.
  */
 export function useToggleButton(props: AriaToggleButtonProps<ElementType>, state: ToggleState, ref: RefObject<any>): ButtonAria<HTMLAttributes<any>> {
-/* eslint-enable no-redeclare */
   const {isSelected} = state;
   const {isPressed, buttonProps} = useButton({
     ...props,