Skip to content

Commit 0276c10

Browse files
committed
chore: delete modal outside click hander to close, use html attr instead
1 parent dd126d7 commit 0276c10

1 file changed

Lines changed: 1 addition & 11 deletions

File tree

blocks/modal/modal.js

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ import {
1212
export async function createModal(contentNodes) {
1313
await loadCSS(`${window.hlx.codeBasePath}/blocks/modal/modal.css`);
1414
const dialog = document.createElement('dialog');
15+
dialog.setAttribute('closedby', 'any');
1516
const dialogContent = document.createElement('div');
1617
dialogContent.classList.add('modal-content');
1718
dialogContent.append(...contentNodes);
@@ -30,17 +31,6 @@ export async function createModal(contentNodes) {
3031
decorateBlock(block);
3132
await loadBlock(block);
3233

33-
// close on click outside the dialog
34-
dialog.addEventListener('click', (e) => {
35-
const {
36-
left, right, top, bottom,
37-
} = dialog.getBoundingClientRect();
38-
const { clientX, clientY } = e;
39-
if (clientX < left || clientX > right || clientY < top || clientY > bottom) {
40-
dialog.close();
41-
}
42-
});
43-
4434
dialog.addEventListener('close', () => {
4535
document.body.classList.remove('modal-open');
4636
block.remove();

0 commit comments

Comments
 (0)