Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMakeLists.txt contains incorrect version, which is propagated to installed actsvg-config.cmake #94

Open
wdconinc opened this issue Jan 11, 2025 · 3 comments
Open

CMakeLists.txt contains incorrect version, which is propagated to installed actsvg-config.cmake #94

wdconinc opened this issue Jan 11, 2025 · 3 comments

Comments

@wdconinc
Copy link
Contributor

See https://github.com/acts-project/actsvg/blob/v0.4.50/CMakeLists.txt#L3:

project(actsvg VERSION 0.4.41 LANGUAGES CXX)

This results in ACTS build failures, e.g. https://gitlab.spack.io/spack/spack/-/jobs/14618992#L1719.
@wdconinc wdconinc mentioned this issue Jan 11, 2025
Merged
@wdconinc
Copy link
Contributor Author

wdconinc commented Mar 6, 2025

@stephenswat @paulgessinger This is still an issue preventing acts +svg in spack (and therefore +traccc). Not sure if this warrants a complete release workflow for actsvg...

@paulgessinger
Copy link
Member

Oh, I see. I think we can fix this.

@paulgessinger
Copy link
Member

I created a tag v0.4.51 https://github.com/acts-project/actsvg/releases/tag/v0.4.51 which has the version set correctly in CMake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@paulgessinger @wdconinc