Fixed Ability for IATS Gateway to make purchased using 'CustomerCode' ('stored' card token) #2467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Store and Unstore methods were already implimented Passing the Stored token to purchase would return an error. Finished implimenting 'ProcessCreditCardWithCustomerCodeV1' Added Unit Test Added Remote Test
bdewater
reviewed
Jun 21, 2017
| add_description(post, options) | ||
|
|
||
| commit((payment.is_a?(Check) ? :purchase_check : :purchase), post) | ||
| commit((payment.is_a?(Check) ? :purchase_check : payment.is_a?(String) ? :purchase_token : :purchase), post) |
Contributor
There was a problem hiding this comment.
Nested ternary operators 🙅♂️ could you please change this to something similar to the structure used in add_payment?
Contributor
|
@bdewater Is this something you're still interested in landing? |
|
To provide a cleaner slate for the maintenance of the library, this PR/Issue is being labeled stale after 60 days without activity. It will be closed in 14 days unless you comment with an update regarding its applicability to the current build. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Store and Unstore methods were already implemented
Passing the 'stored token' to purchase would return an error.
Implimented 'ProcessCreditCardWithCustomerCodeV1'
Added Unit Test
Added Remote Test