Merge pull request #13 from actiontech/fix/type-error

fix: prevent undefined column access in SQL result viewer

Author: LordofAvernus

webapp/packages/core-sdk/src/ServerInternalError.ts

@@ -28,6 +28,6 @@ export class ServerInternalError extends DetailsError implements ServerError {
   }
 
   hasDetails(): boolean {
-    return this.stack !== undefined && this.stack.length > 0 && this.errorType !== ServerErrorType.QUOTE_EXCEEDED;
+    return this.stack !== undefined && (this.stack?.length ?? 0) > 0 && this.errorType !== ServerErrorType.QUOTE_EXCEEDED;
   }
 }

webapp/packages/plugin-data-viewer/src/DatabaseDataModel/Actions/ResultSet/ResultSetFormatAction.ts

@@ -38,7 +38,7 @@ export class ResultSetFormatAction
   }
 
   getHeaders(): string[] {
-    return this.view.columns.map(column => column.name!).filter(name => name !== undefined);
+    return this.view.columns.map(column => column?.name).filter((name): name is string => name !== undefined && name !== null);
   }
 
   getLongestCells(offset = 0, count?: number): string[] {

webapp/packages/plugin-data-viewer/src/DatabaseDataModel/Actions/ResultSet/ResultSetViewAction.ts

@@ -39,7 +39,7 @@ export class ResultSetViewAction extends DatabaseDataAction<any, IDatabaseResult
   }
 
   get columns(): SqlResultColumn[] {
-    return this.columnsOrder.map(i => this.data.columns[i]);
+    return this.columnsOrder.map(i => this.data.columns[i]).filter(column => column !== undefined);
   }
 
   private columnsOrder: number[] = [];

webapp/packages/plugin-data-viewer/src/TableViewer/TableError.tsx

@@ -215,12 +215,11 @@ export const TableError = observer<Props>(function TableError({ model, loading,
       errorInfo.error = model.source.error || null;
       errorInfo.display = !!model.source.error;
     }
-    console.log(error, model.source.error);
     const isSqlContextError = error.errorCode === SQL_CONTEXT_ERROR_CODE || /SQL context .* not found/i.test(error.message || '');
     if (isSqlContextError) {
       handleReopenEditor();
     }
-  }, [error.message, handleReopenEditor, model.source.error, errorInfo]);
+  }, [error.message, handleReopenEditor, model.source.error, errorInfo, error.errorCode]);
 
   return styled(style)(
     <error {...use({ animated, collapsed: !errorInfo.display, errorHidden })} className={className}>