Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actions fails if rate Limit is not enabled #1156

Open
ggabijaa opened this issue Apr 27, 2024 · 6 comments
Open

Actions fails if rate Limit is not enabled #1156

ggabijaa opened this issue Apr 27, 2024 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@ggabijaa
Copy link

ggabijaa commented Apr 27, 2024

Description:
When running action on schedule errors due to rateLimit. The actions is marked as successful but logs were showing errors:
image

Is this expected behavior? Should action error out when rateLimit, not enabled?

Action version: V9

Platform: Rocky Linux

Runner type: Self-hosted

Workfkow config:

name: Mark Stale Pull Requests

on:
  schedule:
    - cron: '0 1 * * *'

permissions:
  issues: write
  pull-requests: write


jobs:
  stale:
    runs-on: [self-hosted, rocky]
    steps:
      - uses: actions/stale@v9
        with:
          days-before-stale: 3
          stale-pr-label: 'stale'
          labels-to-remove-when-unstale: 'stale'
          days-before-close: -1
@ggabijaa ggabijaa added bug Something isn't working needs triage labels Apr 27, 2024
@HarithaVattikuti
Copy link
Contributor

Hello @ggabijaa
Thank you for creating this issue. We will investigate it and get back to you as soon as we have some feedback.

@martin-majlis-s1
Copy link

When I check the documentation - https://docs.github.com/en/[email protected]/admin/configuring-settings/configuring-user-applications-for-your-enterprise/configuring-rate-limits#about-rate-limits-for-github-actions - I can see, that it says:

By default, the rate limit for GitHub Actions is disabled. Because GitHub Enterprise Server can handle temporary spikes in usage without performance degradation, this rate limit is intended to protect against sustained high load. We recommend leaving the rate limit disabled unless you are experiencing performance problems. In some cases, GitHub Support may recommend that you enable a rate limit for GitHub Actions.

Not having a rate limit is expected state and it should not be logged as an error - https://github.com/actions/stale/blob/main/src/classes/issues-processor.ts#L648

What do you think?

@nunosousa-dev
Copy link

Is this still being analyzed? At least a flag to not check for rate limites could be considered, or just remove this error print for GH Enterprise instances. Thank you.

@suyashgaonkar
Copy link

Hi @ggabijaa , We tried to investigate the issue with the provided details on a self hosted runner and we see that the workflow seems to work fine without any rate limit issue. It will really helpful if you could share a link to a public repository to help us with further investigation on the issue.

@suyashgaonkar
Copy link

Hi @ggabijaa , We are awaiting for your response, you can let us know if you have any queriers or the issue still exists.

@ggabijaa
Copy link
Author

hello, yes workflow does work and is marked as successful, however error is printed. I cant send you the link of the repository, as its enterprise. Action works as expected in public Github.

Attaching logs for the workflow run in enterprise:

2024-12-30T12:58:22.0421334Z Requested labels: self-hosted
2024-12-30T12:58:22.0421465Z Job defined at: test-org/test-repo/.github/workflows/mark_stale.yaml@refs/heads/main
2024-12-30T12:58:22.0421544Z Waiting for a runner to pick up this job...
2024-12-30T12:58:22.9399996Z Job is about to start running on the runner: runner-runner1 (enterprise)
2024-12-30T12:58:40.5542857Z Current runner version: '2.321.0'
2024-12-30T12:58:40.5560032Z Runner name: 'runner-runner1'
2024-12-30T12:58:40.5563264Z Runner group name: 'Runners'
2024-12-30T12:58:40.5566482Z Machine name: 'runnervm'
2024-12-30T12:58:40.5578943Z ##[group]GITHUB_TOKEN Permissions
2024-12-30T12:58:40.5584246Z Issues: write
2024-12-30T12:58:40.5586215Z Metadata: read
2024-12-30T12:58:40.5588166Z PullRequests: write
2024-12-30T12:58:40.5590541Z ##[endgroup]
2024-12-30T12:58:40.5594874Z Secret source: Actions
2024-12-30T12:58:40.5597218Z Prepare workflow directory
2024-12-30T12:58:40.6409272Z Prepare all required actions
2024-12-30T12:58:40.6481760Z Getting action download info
2024-12-30T12:58:40.8520820Z Download action repository 'actions/stale@v9' (SHA:28ca1036281a5e5922ead5184a1bbf96e5fc984e)
2024-12-30T12:58:41.9558465Z Complete job name: stale
2024-12-30T12:58:42.1721638Z ##[group]Run actions/stale@v9
2024-12-30T12:58:42.1725520Z with:
2024-12-30T12:58:42.1728150Z   days-before-stale: 0
2024-12-30T12:58:42.1731423Z   stale-pr-label: stale
2024-12-30T12:58:42.1734642Z   labels-to-remove-when-unstale: stale
2024-12-30T12:58:42.1738392Z   days-before-close: -1
2024-12-30T12:58:42.1742334Z   repo-token: ***
2024-12-30T12:58:42.1744689Z   stale-issue-label: Stale
2024-12-30T12:58:42.1748067Z   close-issue-reason: not_planned
2024-12-30T12:58:42.1751947Z   exempt-all-milestones: false
2024-12-30T12:58:42.1755514Z   operations-per-run: 30
2024-12-30T12:58:42.1758969Z   remove-stale-when-updated: true
2024-12-30T12:58:42.1762654Z   debug-only: false
2024-12-30T12:58:42.1765665Z   ascending: false
2024-12-30T12:58:42.1768701Z   delete-branch: false
2024-12-30T12:58:42.1772038Z   exempt-all-assignees: false
2024-12-30T12:58:42.1775598Z   exempt-draft-pr: false
2024-12-30T12:58:42.1779090Z   enable-statistics: true
2024-12-30T12:58:42.1782517Z   ignore-updates: false
2024-12-30T12:58:42.1785815Z   include-only-assigned: false
2024-12-30T12:58:42.1789991Z env:
2024-12-30T12:58:42.1792738Z   STALE_LABEL: stale
2024-12-30T12:58:42.1795732Z ##[endgroup]
2024-12-30T12:58:44.2238006Z The saved state was not found, the process starts from the first issue.
2024-12-30T12:58:44.2532435Z �[97m�[33mStarting the stale action process...�[39m�[39m
2024-12-30T12:58:44.2741795Z ##[error]�[97mError when getting rateLimit: Rate limiting is not enabled.�[39m
2024-12-30T12:58:44.3381170Z �[97m�[33mProcessing the batch of issues �[39m �[36m#1�[39m �[33m containing �[39m �[36m3�[39m �[33m issues...�[39m�[39m
2024-12-30T12:58:44.3390994Z ##[group]�[97m�[34m[#90]�[39m Pull request #90�[39m
2024-12-30T12:58:44.3394544Z �[97m�[34m[#90]�[39m Found this pull request last updated at: �[36m2024-12-12T13:01:16Z�[39m�[39m
2024-12-30T12:58:44.3401172Z �[97m�[34m[#90]�[39m The option �[35monly-labels (​https://github.com/actions/stale#only-labels​)�[39m was not specified�[39m
2024-12-30T12:58:44.3403692Z �[97m�[34m[#90]�[39m �[37m└──�[39m Continuing the process for this pull request�[39m
2024-12-30T12:58:44.3404830Z �[97m�[34m[#90]�[39m Days before pull request stale: �[36m0�[39m�[39m
2024-12-30T12:58:44.3406200Z �[97m�[34m[#90]�[39m The pull request is not closed nor locked. Trying to remove the close label...�[39m
2024-12-30T12:58:44.3407864Z �[97m�[34m[#90]�[39m �[37m├──�[39m The �[35mclose-pr-label (​https://github.com/actions/stale#close-pr-label​)�[39m option was not set�[39m
2024-12-30T12:58:44.3409415Z �[97m�[34m[#90]�[39m �[37m└──�[39m Skipping the removal of the close label�[39m
2024-12-30T12:58:44.3410974Z �[97m�[34m[#90]�[39m This pull request does not include a stale label�[39m
2024-12-30T12:58:44.3412781Z �[97m�[34m[#90]�[39m The option �[35many-of-labels (​https://github.com/actions/stale#any-of-labels​)�[39m was not specified�[39m
2024-12-30T12:58:44.3414563Z �[97m�[34m[#90]�[39m �[37m└──�[39m Continuing the process for this pull request�[39m
2024-12-30T12:58:44.3415745Z �[97m�[34m[#90]�[39m This pull request has no milestone�[39m
2024-12-30T12:58:44.3417434Z �[97m�[34m[#90]�[39m �[37m└──�[39m Skip the milestones checks�[39m
2024-12-30T12:58:44.3420306Z �[97m�[34m[#90]�[39m This pull request has no assignee�[39m
2024-12-30T12:58:44.3421945Z �[97m�[34m[#90]�[39m �[37m└──�[39m Skip the assignees checks�[39m
2024-12-30T12:58:44.3423014Z �[97m�[34m[#90]�[39m This pull request is not stale�[39m
2024-12-30T12:58:44.3426559Z �[97m�[34m[#90]�[39m The option �[35mignore-updates (​https://github.com/actions/stale#ignore-updates​)�[39m is disabled. The stale counter will take into account updates and comments on this pull request to avoid to stale when there is some update�[39m
2024-12-30T12:58:44.3430818Z �[97m�[34m[#90]�[39m This pull request should be stale based on the last update date the 12-12-2024 (�[36m2024-12-12T13:01:16Z�[39m)�[39m
2024-12-30T12:58:44.3434498Z �[97m�[34m[#90]�[39m This pull request should be marked as stale based on the option �[35mdays-before-stale (​https://github.com/actions/stale#days-before-stale​)�[39m (�[36m0�[39m)�[39m
2024-12-30T12:58:44.3437281Z �[97m�[34m[#90]�[39m Marking this pull request as stale�[39m
2024-12-30T12:58:44.5864657Z �[97m�[34m[#90]�[39m This pull request is now stale�[39m
2024-12-30T12:58:44.5866328Z �[97m�[34m[#90]�[39m This pull request is already stale�[39m
2024-12-30T12:58:44.5867918Z �[97m�[34m[#90]�[39m Checking for label on this pull request�[39m
2024-12-30T12:58:44.6656759Z �[97m�[34m[#90]�[39m Pull request marked stale on: �[36m2024-12-30T12:58:44Z�[39m�[39m
2024-12-30T12:58:44.6658974Z �[97m�[34m[#90]�[39m Checking for comments on pull request since: �[36m2024-12-30T12:58:44Z�[39m�[39m
2024-12-30T12:58:44.7277016Z �[97m�[34m[#90]�[39m Comments that are not the stale comment or another bot: �[36m0�[39m�[39m
2024-12-30T12:58:44.7279284Z �[97m�[34m[#90]�[39m Pull request has been commented on: �[36mfalse�[39m�[39m
2024-12-30T12:58:44.7281064Z �[97m�[34m[#90]�[39m Days before pull request close: �[36m-1�[39m�[39m
2024-12-30T12:58:44.7284044Z �[97m�[34m[#90]�[39m The option �[35mremove-stale-when-updated (​https://github.com/actions/stale#remove-stale-when-updated​)�[39m is: �[36mtrue�[39m�[39m
2024-12-30T12:58:44.7286555Z �[97m�[34m[#90]�[39m The stale label should not be removed�[39m
2024-12-30T12:58:44.7288134Z �[97m�[34m[#90]�[39m marked stale this run, so don't check for updates�[39m
2024-12-30T12:58:44.7290372Z �[97m�[34m[#90]�[39m Pull request has been updated since it was marked stale: �[36mfalse�[39m�[39m
2024-12-30T12:58:44.7292281Z �[97m�[34m[#90]�[39m �[36m3�[39m operations consumed for this pull request�[39m
2024-12-30T12:58:44.7295267Z ##[endgroup]
2024-12-30T12:58:44.7297512Z ##[group]�[97m�[34m[#87]�[39m Pull request #87�[39m
2024-12-30T12:58:44.7299342Z �[97m�[34m[#87]�[39m Found this pull request last updated at: �[36m2024-08-12T12:56:13Z�[39m�[39m
2024-12-30T12:58:44.7302020Z �[97m�[34m[#87]�[39m The option �[35monly-labels (​https://github.com/actions/stale#only-labels​)�[39m was not specified�[39m
2024-12-30T12:58:44.7304384Z �[97m�[34m[#87]�[39m �[37m└──�[39m Continuing the process for this pull request�[39m
2024-12-30T12:58:44.7306044Z �[97m�[34m[#87]�[39m Days before pull request stale: �[36m0�[39m�[39m
2024-12-30T12:58:44.7307986Z �[97m�[34m[#87]�[39m The pull request is not closed nor locked. Trying to remove the close label...�[39m
2024-12-30T12:58:44.7310787Z �[97m�[34m[#87]�[39m �[37m├──�[39m The �[35mclose-pr-label (​https://github.com/actions/stale#close-pr-label​)�[39m option was not set�[39m
2024-12-30T12:58:44.7313058Z �[97m�[34m[#87]�[39m �[37m└──�[39m Skipping the removal of the close label�[39m
2024-12-30T12:58:44.7314723Z �[97m�[34m[#87]�[39m This pull request does not include a stale label�[39m
2024-12-30T12:58:44.7317055Z �[97m�[34m[#87]�[39m The option �[35many-of-labels (​https://github.com/actions/stale#any-of-labels​)�[39m was not specified�[39m
2024-12-30T12:58:44.7319435Z �[97m�[34m[#87]�[39m �[37m└──�[39m Continuing the process for this pull request�[39m
2024-12-30T12:58:44.7321144Z �[97m�[34m[#87]�[39m This pull request has no milestone�[39m
2024-12-30T12:58:44.7322580Z �[97m�[34m[#87]�[39m �[37m└──�[39m Skip the milestones checks�[39m
2024-12-30T12:58:44.7324579Z �[97m�[34m[#87]�[39m This pull request has no assignee�[39m
2024-12-30T12:58:44.7326030Z �[97m�[34m[#87]�[39m �[37m└──�[39m Skip the assignees checks�[39m
2024-12-30T12:58:44.7327505Z �[97m�[34m[#87]�[39m This pull request is not stale�[39m
2024-12-30T12:58:44.7331433Z �[97m�[34m[#87]�[39m The option �[35mignore-updates (​https://github.com/actions/stale#ignore-updates​)�[39m is disabled. The stale counter will take into account updates and comments on this pull request to avoid to stale when there is some update�[39m
2024-12-30T12:58:44.7335693Z �[97m�[34m[#87]�[39m This pull request should be stale based on the last update date the 12-08-2024 (�[36m2024-08-12T12:56:13Z�[39m)�[39m
2024-12-30T12:58:44.7339733Z �[97m�[34m[#87]�[39m This pull request should be marked as stale based on the option �[35mdays-before-stale (​https://github.com/actions/stale#days-before-stale​)�[39m (�[36m0�[39m)�[39m
2024-12-30T12:58:44.7342828Z �[97m�[34m[#87]�[39m Marking this pull request as stale�[39m
2024-12-30T12:58:44.9515877Z �[97m�[34m[#87]�[39m This pull request is now stale�[39m
2024-12-30T12:58:44.9517331Z �[97m�[34m[#87]�[39m This pull request is already stale�[39m
2024-12-30T12:58:44.9518886Z �[97m�[34m[#87]�[39m Checking for label on this pull request�[39m
2024-12-30T12:58:45.0539001Z �[97m�[34m[#87]�[39m Pull request marked stale on: �[36m2024-12-30T12:58:44Z�[39m�[39m
2024-12-30T12:58:45.0541340Z �[97m�[34m[#87]�[39m Checking for comments on pull request since: �[36m2024-12-30T12:58:44Z�[39m�[39m
2024-12-30T12:58:45.1201311Z �[97m�[34m[#87]�[39m Comments that are not the stale comment or another bot: �[36m0�[39m�[39m
2024-12-30T12:58:45.1203300Z �[97m�[34m[#87]�[39m Pull request has been commented on: �[36mfalse�[39m�[39m
2024-12-30T12:58:45.1204913Z �[97m�[34m[#87]�[39m Days before pull request close: �[36m-1�[39m�[39m
2024-12-30T12:58:45.1207677Z �[97m�[34m[#87]�[39m The option �[35mremove-stale-when-updated (​https://github.com/actions/stale#remove-stale-when-updated​)�[39m is: �[36mtrue�[39m�[39m
2024-12-30T12:58:45.1210354Z �[97m�[34m[#87]�[39m The stale label should not be removed�[39m
2024-12-30T12:58:45.1212105Z �[97m�[34m[#87]�[39m marked stale this run, so don't check for updates�[39m
2024-12-30T12:58:45.1214004Z �[97m�[34m[#87]�[39m Pull request has been updated since it was marked stale: �[36mfalse�[39m�[39m
2024-12-30T12:58:45.1215910Z �[97m�[34m[#87]�[39m �[36m3�[39m operations consumed for this pull request�[39m
2024-12-30T12:58:45.1218020Z ##[endgroup]
2024-12-30T12:58:45.1220235Z ##[group]�[97m�[34m[#82]�[39m Pull request #82�[39m
2024-12-30T12:58:45.1221979Z �[97m�[34m[#82]�[39m Found this pull request last updated at: �[36m2024-07-19T17:38:27Z�[39m�[39m
2024-12-30T12:58:45.1224456Z �[97m�[34m[#82]�[39m The option �[35monly-labels (​https://github.com/actions/stale#only-labels​)�[39m was not specified�[39m
2024-12-30T12:58:45.1226780Z �[97m�[34m[#82]�[39m �[37m└──�[39m Continuing the process for this pull request�[39m
2024-12-30T12:58:45.1228438Z �[97m�[34m[#82]�[39m Days before pull request stale: �[36m0�[39m�[39m
2024-12-30T12:58:45.1230725Z �[97m�[34m[#82]�[39m The pull request is not closed nor locked. Trying to remove the close label...�[39m
2024-12-30T12:58:45.1233480Z �[97m�[34m[#82]�[39m �[37m├──�[39m The �[35mclose-pr-label (​https://github.com/actions/stale#close-pr-label​)�[39m option was not set�[39m
2024-12-30T12:58:45.1235798Z �[97m�[34m[#82]�[39m �[37m└──�[39m Skipping the removal of the close label�[39m
2024-12-30T12:58:45.1237470Z �[97m�[34m[#82]�[39m This pull request does not include a stale label�[39m
2024-12-30T12:58:45.1240197Z �[97m�[34m[#82]�[39m The option �[35many-of-labels (​https://github.com/actions/stale#any-of-labels​)�[39m was not specified�[39m
2024-12-30T12:58:45.1242499Z �[97m�[34m[#82]�[39m �[37m└──�[39m Continuing the process for this pull request�[39m
2024-12-30T12:58:45.1244167Z �[97m�[34m[#82]�[39m This pull request has no milestone�[39m
2024-12-30T12:58:45.1245625Z �[97m�[34m[#82]�[39m �[37m└──�[39m Skip the milestones checks�[39m
2024-12-30T12:58:45.1247674Z �[97m�[34m[#82]�[39m This pull request has no assignee�[39m
2024-12-30T12:58:45.1249279Z �[97m�[34m[#82]�[39m �[37m└──�[39m Skip the assignees checks�[39m
2024-12-30T12:58:45.1250825Z �[97m�[34m[#82]�[39m This pull request is not stale�[39m
2024-12-30T12:58:45.1254500Z �[97m�[34m[#82]�[39m The option �[35mignore-updates (​https://github.com/actions/stale#ignore-updates​)�[39m is disabled. The stale counter will take into account updates and comments on this pull request to avoid to stale when there is some update�[39m
2024-12-30T12:58:45.1258744Z �[97m�[34m[#82]�[39m This pull request should be stale based on the last update date the 19-07-2024 (�[36m2024-07-19T17:38:27Z�[39m)�[39m
2024-12-30T12:58:45.1262521Z �[97m�[34m[#82]�[39m This pull request should be marked as stale based on the option �[35mdays-before-stale (​https://github.com/actions/stale#days-before-stale​)�[39m (�[36m0�[39m)�[39m
2024-12-30T12:58:45.1265159Z �[97m�[34m[#82]�[39m Marking this pull request as stale�[39m
2024-12-30T12:58:45.3617165Z �[97m�[34m[#82]�[39m This pull request is now stale�[39m
2024-12-30T12:58:45.3618719Z �[97m�[34m[#82]�[39m This pull request is already stale�[39m
2024-12-30T12:58:45.3620492Z �[97m�[34m[#82]�[39m Checking for label on this pull request�[39m
2024-12-30T12:58:45.4763070Z �[97m�[34m[#82]�[39m Pull request marked stale on: �[36m2024-12-30T12:58:45Z�[39m�[39m
2024-12-30T12:58:45.4765165Z �[97m�[34m[#82]�[39m Checking for comments on pull request since: �[36m2024-12-30T12:58:45Z�[39m�[39m
2024-12-30T12:58:45.5542522Z �[97m�[34m[#82]�[39m Comments that are not the stale comment or another bot: �[36m0�[39m�[39m
2024-12-30T12:58:45.5544452Z �[97m�[34m[#82]�[39m Pull request has been commented on: �[36mfalse�[39m�[39m
2024-12-30T12:58:45.5546123Z �[97m�[34m[#82]�[39m Days before pull request close: �[36m-1�[39m�[39m
2024-12-30T12:58:45.5548980Z �[97m�[34m[#82]�[39m The option �[35mremove-stale-when-updated (​https://github.com/actions/stale#remove-stale-when-updated​)�[39m is: �[36mtrue�[39m�[39m
2024-12-30T12:58:45.5551524Z �[97m�[34m[#82]�[39m The stale label should not be removed�[39m
2024-12-30T12:58:45.5553124Z �[97m�[34m[#82]�[39m marked stale this run, so don't check for updates�[39m
2024-12-30T12:58:45.5555149Z �[97m�[34m[#82]�[39m Pull request has been updated since it was marked stale: �[36mfalse�[39m�[39m
2024-12-30T12:58:45.5557039Z �[97m�[34m[#82]�[39m �[36m3�[39m operations consumed for this pull request�[39m
2024-12-30T12:58:45.5559385Z ##[endgroup]
2024-12-30T12:58:45.5561142Z �[97m�[32mBatch �[39m �[36m#1�[39m �[32m processed.�[39m�[39m
2024-12-30T12:58:45.5964543Z �[97m�[32mNo more issues found to process. Exiting...�[39m�[39m
2024-12-30T12:58:45.5966019Z �[97m�[33m�[1mStatistics:�[22m�[39m�[39m
2024-12-30T12:58:45.5967175Z �[97mProcessed PRs: �[36m3�[39m�[39m
2024-12-30T12:58:45.5968259Z �[97mNew stale PRs: �[36m3�[39m�[39m
2024-12-30T12:58:45.5969522Z �[97mAdded PRs labels: �[36m3�[39m�[39m
2024-12-30T12:58:45.5970825Z �[97mFetched items: �[36m3�[39m�[39m
2024-12-30T12:58:45.5971965Z �[97mFetched items events: �[36m3�[39m�[39m
2024-12-30T12:58:45.5973184Z �[97mFetched items comments: �[36m3�[39m�[39m
2024-12-30T12:58:45.5974384Z �[97mOperations performed: �[36m11�[39m�[39m
2024-12-30T12:58:45.6264856Z ##[error]�[97mError when getting rateLimit: Rate limiting is not enabled.�[39m
2024-12-30T12:58:45.6267890Z state: persisting info about 0 issue(s)
2024-12-30T12:58:45.6875660Z the state will be removed
2024-12-30T12:58:45.7211771Z Cleaning up orphan processes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants