Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion/Request: wine-patched + pba repo #10

Open
IngeniousDox opened this issue Feb 27, 2018 · 4 comments
Open

Suggestion/Request: wine-patched + pba repo #10

IngeniousDox opened this issue Feb 27, 2018 · 4 comments

Comments

@IngeniousDox
Copy link

IngeniousDox commented Feb 27, 2018

Right now you just have the patches in this repo. It would however be handy to have a full wine repo based on staging 2.21 + your patches. This would skip the patching step for everyone that wants to test, and strider/strycore can then also make builds faster for Lutris (buildbot that makes wine from githubrepo). This will increase your tester base considerably.

Wine Staging (old) has a wine-patched repo. You could clone it, check out tag Staging 2.21, set it as master branch, and push your patches on top of it.

@jrugia
Copy link

jrugia commented Feb 28, 2018

I think this is a good idea for more testing, it's also important that the patches would still be separately downloadable though.

@IngeniousDox
Copy link
Author

It is possible to have 2 repos. Just keep this for the patches, and have a wine-pba-patched repo for the patched version. I'm assuming accomminos is using git already to make the patches. So it would be just a push to the repo for him from his master branch.

I have thought of making a patched one, but that would introduce lag in the process. Since I'm asleep when acomminos is posting patches it seems. And then I would have to apply patches, and I might not always have time for it. Skipping me will allow people to warn Strider on Discord when a new build is needed and he can build it.

@acomminos
Copy link
Owner

I can probably hack together a commit hook for applying these patches to a repo later this week.

I don't expect these patches to be landing for a while, but it's useful for me to keep a patch-only repo so I can regroup commits logically down the road.

@IngeniousDox
Copy link
Author

Sounds good. Keeps everything central in your github repos. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants