Fix memory leak in FatIFileAccess error handling

stokescat · stokescat · commit b88b3a6c6729 · 2025-11-10T21:21:53.000+03:00
A memory leak was discovered during fuzz testing:
- The async task object (Task) created in FatIFileAccess
  was not being freed when FatGrowEof() returned an error

Changes:
- Moved the "Done" label to precede the "Task" check in
  if-then branch

Signed-off-by: Pavel Naberezhnev &lt;pavelnaberezhnev@gmail.com&gt;
diff --git a/FatPkg/EnhancedFatDxe/ReadWrite.c b/FatPkg/EnhancedFatDxe/ReadWrite.c
@@ -318,6 +318,8 @@ FatIFileAccess (
     }
   }
 
+Done:
+
   if (Token != NULL) {
     if (!EFI_ERROR (Status)) {
       Status = FatQueueTask (IFile, Task);
@@ -326,7 +328,6 @@ FatIFileAccess (
     }
   }
 
-Done:
   //
   // On EFI_SUCCESS case, not calling FatCleanupVolume():
   // 1) The Cache flush operation is avoided to enhance

Original file line number	Diff line number	Diff line change
`@@ -318,6 +318,8 @@ FatIFileAccess (`
`318`	`318`	`}`
`319`	`319`	`}`
`320`	`320`
	`321`	`+Done:`
	`322`	`+`
`321`	`323`	`if (Token != NULL) {`
`322`	`324`	`if (!EFI_ERROR (Status)) {`
`323`	`325`	`Status = FatQueueTask (IFile, Task);`
`@@ -326,7 +328,6 @@ FatIFileAccess (`
`326`	`328`	`}`
`327`	`329`	`}`
`328`	`330`
`329`		`-Done:`
`330`	`331`	`//`
`331`	`332`	`// On EFI_SUCCESS case, not calling FatCleanupVolume():`
`332`	`333`	`// 1) The Cache flush operation is avoided to enhance`