-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new consistency check at boot time: Userfile and CbrainTask classes verification #969
Comments
Data-providers should be included too? @prioux Actually there is a benefit in not having that feature. When one works on several features/PR in the same time, and some of them involve new tasks or userfiles, it is not necessary to wipe up to database after branch switch. Maybe not the case with you, but Natacha, most likely, integrates or tests few new tools in the same time. Well, if still needed, please confirm |
I want that check at boot time, it is an important piece of information. In developement, maybe print a warning about the classes; in production, stop the boot process entirely. Since not all CbrainTask classes are deplpyed on the Bourreaux, the check for the types for the cbrain_tasks table should be restricted to those rows which have an ID matching the current app. For userfiles and data providers, it must be a fatal error always. |
@prioux can you clarify
Do you suggest restrict by
|
Yes exactly. |
Add a new boot-time validation method to check that all the 'type' columns of our single table inheritance models represent ruby classes that are properly loaded.
For tasks, that would be:
The text was updated successfully, but these errors were encountered: