Added nicer frames for web and mobile #193
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I kept the total height of the frame the same so viewable area is now less. Also there's a small stutter in the mobile preview due to iframe content loading late, I'll try to find a workaround if necessary.
Contributor
Apply Sweep Rules to your PR?
|
Yusu-f
changed the title
Elishiaaaaaa
approved these changes
Mar 31, 2024
|
@Elishiaaaaaa as far as I see this pull request wasn't updated for a whole year, would it be a good decision for me to add resizable screen frame (like in DevTools)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I kept the total height of the frame the same so the viewable area is now slightly less. Closes #176