chore: cleanup

Author: abdel-17

sites/preview/src/lib/components/tree/ContextMenu.svelte

@@ -75,17 +75,13 @@
 	};
 
 	function handleCreateFolder(): void {
-		if (showArgs === undefined) {
-			throw new Error("Context menu is closed");
-		}
-
-		switch (showArgs.type) {
+		switch (showArgs!.type) {
 			case "tree": {
 				onCreateFolder(tree);
 				break;
 			}
 			case "item": {
-				const item = showArgs.item();
+				const item = showArgs!.item();
 				if (item.node.type === "file") {
 					throw new Error("Cannot create a folder inside a file");
 				}
@@ -97,22 +93,14 @@
 	}
 
 	function handleUploadFiles(): void {
-		if (showArgs === undefined) {
-			throw new Error("Context menu is closed");
-		}
-
-		if (fileInput === null) {
-			throw new Error("File input is not mounted");
-		}
-
 		let target: FolderNode | FileTree;
-		switch (showArgs.type) {
+		switch (showArgs!.type) {
 			case "tree": {
 				target = tree;
 				break;
 			}
 			case "item": {
-				const item = showArgs.item();
+				const item = showArgs!.item();
 				if (item.node.type === "file") {
 					throw new Error("Cannot upload files inside a file");
 				}
@@ -129,7 +117,7 @@
 
 			onUploadFiles(target, files);
 		};
-		fileInput.click();
+		fileInput!.click();
 	}
 
 	const handleFileInputChange: EventHandler<Event, HTMLInputElement> = (event) => {

sites/preview/src/lib/components/tree/NameFormDialog.svelte

@@ -35,11 +35,7 @@
 	}
 
 	const handleSubmit: EventHandler<SubmitEvent, HTMLFormElement> = (event) => {
-		if (showArgs === undefined) {
-			throw new Error("Dialog is closed");
-		}
-
-		showArgs.onSubmit(name);
+		showArgs!.onSubmit(name);
 		event.preventDefault();
 	};
 </script>

sites/preview/src/lib/components/tree/Tree.svelte

@@ -80,10 +80,6 @@
 		name,
 	}: ResolveNameConflictArgs): Promise<NameConflictResolution> {
 		return new Promise((resolve) => {
-			if (nameConflictDialog === null) {
-				throw new Error("Dialog is not mounted");
-			}
-
 			let title: string;
 			switch (operation) {
 				case "move": {
@@ -96,7 +92,7 @@
 				}
 			}
 
-			nameConflictDialog.show({
+			nameConflictDialog!.show({
 				title,
 				description: `An item with the name "${name}" already exists`,
 				onClose: resolve,
@@ -116,20 +112,12 @@
 	}
 
 	function handleRename(target: TreeItemState<FileTreeNode>): void {
-		if (nameFormDialog === null) {
-			throw new Error("Dialog is not mounted");
-		}
-
-		nameFormDialog.show({
+		nameFormDialog!.show({
 			title: "Rename",
 			initialName: target.node.name,
 			onSubmit: async (name) => {
-				if (nameFormDialog === null) {
-					throw new Error("Dialog is not mounted");
-				}
-
 				if (name === target.node.name) {
-					nameFormDialog.close();
+					nameFormDialog!.close();
 					return;
 				}
 
@@ -143,36 +131,12 @@
 
 				const didRename = await onRenameItem({ target, name });
 				if (didRename) {
-					nameFormDialog.close();
+					nameFormDialog!.close();
 				}
 			},
 		});
 	}
 
-	function handleCopy(target: TreeItemState<FileTreeNode>, operation: PasteOperation): void {
-		if (treeComponent === null) {
-			throw new Error("Tree is not mounted");
-		}
-
-		treeComponent.copy(target, operation);
-	}
-
-	function handlePaste(target: TreeItemState<FileTreeNode>): void {
-		if (treeComponent === null) {
-			throw new Error("Tree is not mounted");
-		}
-
-		treeComponent.paste(target);
-	}
-
-	function handleRemove(target: TreeItemState<FileTreeNode>): void {
-		if (treeComponent === null) {
-			throw new Error("Tree is not mounted");
-		}
-
-		treeComponent.remove(target);
-	}
-
 	function handleUploadFiles(target: FolderNode | FileTree, files: FileList): void {
 		for (const file of files) {
 			const node = new FileNode({
@@ -185,18 +149,10 @@
 	}
 
 	function handleCreateFolder(target: FolderNode | FileTree): void {
-		if (nameFormDialog === null) {
-			throw new Error("Dialog is not mounted");
-		}
-
-		nameFormDialog.show({
+		nameFormDialog!.show({
 			title: "New Folder",
 			initialName: "",
 			onSubmit: (name) => {
-				if (nameFormDialog === null) {
-					throw new Error("Dialog is not mounted");
-				}
-
 				for (const child of target.children) {
 					if (child.name === name) {
 						showAlreadyExistsToast(name);
@@ -210,7 +166,7 @@
 					children: [],
 				});
 				target.children.push(node);
-				nameFormDialog.close();
+				nameFormDialog!.close();
 			},
 		});
 	}
@@ -236,11 +192,7 @@
 	};
 
 	const handleDrop: EventHandler<DragEvent, HTMLDivElement> = (event) => {
-		if (event.defaultPrevented) {
-			return;
-		}
-
-		if (event.dataTransfer === null) {
+		if (event.defaultPrevented || event.dataTransfer === null) {
 			return;
 		}
 
@@ -262,9 +214,9 @@
 		{tree}
 		bind:this={contextMenu}
 		onRename={handleRename}
-		onCopy={handleCopy}
-		onPaste={handlePaste}
-		onRemove={handleRemove}
+		onCopy={(target, operation) => treeComponent!.copy(target, operation)}
+		onPaste={(target) => treeComponent!.paste(target)}
+		onRemove={(target) => treeComponent!.remove(target)}
 		onUploadFiles={handleUploadFiles}
 		onCreateFolder={handleCreateFolder}
 	>

sites/preview/src/lib/components/tree/TreeItem.svelte

@@ -46,11 +46,7 @@
 			return;
 		}
 
-		if (contextMenu === null) {
-			throw new Error("Context menu is not mounted");
-		}
-
-		contextMenu.show({
+		contextMenu!.show({
 			type: "item",
 			item: () => item,
 		});
@@ -66,10 +62,6 @@
 	};
 
 	const handleToggleClick: EventHandler<MouseEvent, HTMLButtonElement> = (event) => {
-		if (ref === null) {
-			throw new Error("Tree item is not mounted");
-		}
-
 		if (item.disabled) {
 			return;
 		}
@@ -80,17 +72,13 @@
 			onExpand(item);
 		}
 
-		ref.focus();
+		ref!.focus();
 		event.stopPropagation();
 	};
 
 	$effect(() => {
 		return () => {
-			if (contextMenu === null) {
-				throw new Error("Context menu is not mounted");
-			}
-
-			contextMenu.onItemDestroyed(item);
+			contextMenu!.onItemDestroyed(item);
 		};
 	});
 </script>