cleanup

Author: abdel-17

sites/preview/src/lib/components/tree/NameConflictDialog.svelte

@@ -16,10 +16,6 @@
 	}
 
 	export function show(args: ShowArgs): void {
-		if (showArgs !== undefined) {
-			throw new Error("Dialog is already open");
-		}
-
 		showArgs = args;
 	}
 

sites/preview/src/lib/components/tree/NameFormDialog.svelte

@@ -19,10 +19,6 @@
 	}
 
 	export function show(args: ShowArgs): void {
-		if (showArgs !== undefined) {
-			throw new Error("Dialog is already open");
-		}
-
 		showArgs = args;
 		name = args.initialName;
 	}

sites/preview/src/lib/components/tree/Tree.svelte

@@ -120,8 +120,12 @@
 			title: "Rename",
 			initialName: target.node.name,
 			onSubmit: async (name) => {
+				if (nameFormDialog === null) {
+					throw new Error("Dialog is not mounted");
+				}
+
 				if (name === target.node.name) {
-					nameFormDialog?.close();
+					nameFormDialog.close();
 					return;
 				}
 
@@ -135,7 +139,7 @@
 
 				const didRename = await onRenameItem({ target, name });
 				if (didRename) {
-					nameFormDialog?.close();
+					nameFormDialog.close();
 				}
 			},
 		});
@@ -185,6 +189,10 @@
 			title: "New Folder",
 			initialName: "",
 			onSubmit: (name) => {
+				if (nameFormDialog === null) {
+					throw new Error("Dialog is not mounted");
+				}
+
 				for (const child of target.children) {
 					if (child.name === name) {
 						showAlreadyExistsToast(name);
@@ -198,7 +206,7 @@
 					children: [],
 				});
 				target.children.push(node);
-				nameFormDialog?.close();
+				nameFormDialog.close();
 			},
 		});
 	}

sites/preview/src/lib/components/tree/TreeItem.svelte

@@ -73,7 +73,11 @@
 
 	$effect(() => {
 		return () => {
-			contextMenu?.onItemDestroyed(item);
+			if (contextMenu === null) {
+				throw new Error("Context menu is not mounted");
+			}
+
+			contextMenu.onItemDestroyed(item);
 		};
 	});
 </script>