Skip to content

Commit 89310b1

Browse files
committed
refactor: add family args (PR #204)
1 parent d829f34 commit 89310b1

File tree

3 files changed

+67
-0
lines changed

3 files changed

+67
-0
lines changed

.changeset/fuzzy-dancers-unite.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'node-rest-client': minor
3+
---
4+
5+
add family args (PR #204 Update: add family args)
Lines changed: 57 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,57 @@
1+
name: Node-Rest-Client Release
2+
on:
3+
push:
4+
branches:
5+
- feat/general-upgrade
6+
workflow_dispatch:
7+
jobs:
8+
create-release-branch:
9+
runs-on: ubuntu-latest
10+
steps:
11+
- uses: actions/checkout@v3
12+
with:
13+
fetch-depth: 0
14+
fetch-tags: true
15+
16+
17+
18+
# - id: #
19+
# name: configure git
20+
# run: |
21+
# # setup the username and email. I tend to use 'GitHub Actions Bot' with no email by default
22+
# git --version
23+
# git config user.name "GitHub Actions Bot"
24+
# git config user.email "<>"
25+
# git status
26+
# git tag
27+
# git describe
28+
29+
- id: readLatestTag
30+
name: read latest tag
31+
run: echo "latestTag=$(git describe --tags --abbrev=0)" >> "$GITHUB_OUTPUT"
32+
33+
- id: createReleaseBranch
34+
name: create release branch
35+
env:
36+
RELEASE_TAG: ${{ steps.readLatestTag.outputs.latestTag }}
37+
run: |
38+
export BRANCH_NAME="release/$RELEASE_TAG"
39+
git checkout -b $BRANCH_NAME
40+
git push --set-upstream origin release/$RELEASE_TAG
41+
42+
- id: cleanInstallRepo
43+
name: clean install repo
44+
run: npm ci
45+
46+
- id: changesetPR
47+
name: Create Release Pull Request
48+
uses: changesets/action@v1
49+
env:
50+
NRC_RELEASE_MSG: "node-rest-client release ${{ steps.readLatestTag.outputs.latestTag }}"
51+
GITHUB_TOKEN: ${{ secrets.NRC_GITHUB_TOKEN }}
52+
with:
53+
version: npm run version:packages
54+
commit: "chore(release): ${{ env.NRC_RELEASE_MSG }}"
55+
title: "${{ env.NRC_RELEASE_MSG }}"
56+
57+

lib/NrcIoManager.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -540,6 +540,11 @@ export default class NrcIoManager extends events.EventEmitter {
540540
} else {
541541
options.headers[CONSTANTS.HEADER_CONTENT_LENGTH] = 0;
542542
}
543+
544+
// add family arg for fix DNS error, https://github.com/nodejs/node/issues/5436
545+
if (args.family === 4 || args.family === 6) {
546+
options.family = args.family;
547+
}
543548
}
544549

545550
debug('options post connect', options);

0 commit comments

Comments
 (0)