Skip to content

issues Search Results · repo:a-la-node/hapi-project language:JavaScript

Filter by

0 results
 (72 ms)

0 results

ina-la-node/hapi-project (press backspace or delete to remove)

a-la-node/hapi-project
Use of let vs const

Some variables declared using let make more sense as const. For instance, here: if (!error response.statusCode === 200) { let name = JSON.parse(body).results[0].name; let firstName = capitalise(name.first); ...
  • msmichellegar
  • Opened 
    on Nov 23, 2016
  • #73

a-la-node/hapi-project
BEM naming styles

div class= content overlay p You are a... /p ul class= content--options {{#each people}} {{{link this}}} {{/each}} /ul /div If content--options is dependent on content, ...
  • njsfield
  • Opened 
    on Nov 23, 2016
  • #66

a-la-node/hapi-project
Formatting on line 34 in identity.js

return cb(null, randomCity.split( - ).map(word = capitalise(word)).join( )); Perhaps join with a comma and a space, instead of just a space for formatting purposes. So instead of this; image You d ...
  • njsfield
  • Opened 
    on Nov 23, 2016
  • #65

a-la-node/hapi-project
get rid of dem branches

screen shot 2016-11-23 at 16 26 07
  • Jbarget
  • 1
  • Opened 
    on Nov 23, 2016
  • #64

a-la-node/hapi-project
need to add alt text for image

a description under the alt property on an image is needed for screen readers co. https://github.com/a-la-node/hapi-project/blob/master/public/index.html#L2
  • Jbarget
  • 1
  • Opened 
    on Nov 23, 2016
  • #63

a-la-node/hapi-project
Directory for views?

You ve defined some view files (index.html, results-page.html). It may be worth storing them in a directory called views , so in the server.views configuration you can set the path to public/views , just ...
  • njsfield
  • Opened 
    on Nov 23, 2016
  • #62

a-la-node/hapi-project
Can export your server.start out of server.js

https://github.com/a-la-node/hapi-project/blob/master/src/server.js#L69-L72 so that when you re testing your back-end code by requiring in server.js your server wont be started and you wont need to do ...
  • Jbarget
  • 3
  • Opened 
    on Nov 23, 2016
  • #61

a-la-node/hapi-project
Improve Test Coverage by testing your parallel function

  • njsfield
  • 2
  • Opened 
    on Nov 23, 2016
  • #60

a-la-node/hapi-project
Lots of vars in server side code

You could use let, lovely lovely let :)
  • Jwhiles
  • 3
  • Opened 
    on Nov 23, 2016
  • #59

a-la-node/hapi-project
use tests with mock response object

instead of just cheking that you don t get an error and the length is not zero, you can use mock responses and check actual values.
  • denesnori
  • Opened 
    on Nov 23, 2016
  • #58
Issue origami icon

Learn how you can use GitHub Issues to plan and track your work.

Save views for sprints, backlogs, teams, or releases. Rank, sort, and filter issues to suit the occasion. The possibilities are endless.Learn more about GitHub Issues
ProTip! 
Press the
/
key to activate the search input again and adjust your query.
Issue origami icon

Learn how you can use GitHub Issues to plan and track your work.

Save views for sprints, backlogs, teams, or releases. Rank, sort, and filter issues to suit the occasion. The possibilities are endless.Learn more about GitHub Issues
ProTip! 
Restrict your search to the title by using the in:title qualifier.
Issue search results · GitHub