diff --git a/build-common.xml b/build-common.xml index c407de51cc8..185d317e799 100644 --- a/build-common.xml +++ b/build-common.xml @@ -319,7 +319,6 @@ - diff --git a/store/src/java-test/com/zimbra/cs/html/owasp/OwaspHtmlSanitizerTest.java b/store/src/java-test/com/zimbra/cs/html/owasp/OwaspHtmlSanitizerTest.java index 9bc2b94f480..8e93f955a1e 100644 --- a/store/src/java-test/com/zimbra/cs/html/owasp/OwaspHtmlSanitizerTest.java +++ b/store/src/java-test/com/zimbra/cs/html/owasp/OwaspHtmlSanitizerTest.java @@ -720,6 +720,6 @@ public void testBugTSS18004() throws Exception { + "style=\"font-size:11pt;font-family:Arial;font-variant-ligatures:normal;font-variant-east-asian:normal;font-variant-position:normal;vertical-align:baseline\">ave\n" + "a nice day.

"; // check that the extra double quotes are removed - Assert.assertTrue(output.equals(result.trim())); + Assert.assertTrue("Verification failed: Failed to remove extra double quotes.", output.equals(result.trim())); } } diff --git a/store/src/java/com/zimbra/cs/html/owasp/OwaspHtmlSanitizer.java b/store/src/java/com/zimbra/cs/html/owasp/OwaspHtmlSanitizer.java index fd2c16486ed..56f364dba05 100644 --- a/store/src/java/com/zimbra/cs/html/owasp/OwaspHtmlSanitizer.java +++ b/store/src/java/com/zimbra/cs/html/owasp/OwaspHtmlSanitizer.java @@ -66,11 +66,11 @@ public String sanitize() throws UnsupportedEncodingException { return processSanitization(true).toString(); } - public String sanitize(boolean cleanData) throws UnsupportedEncodingException { - return processSanitization(cleanData).toString(); + public String sanitize(boolean cleanMalformedHtml) throws UnsupportedEncodingException { + return processSanitization(cleanMalformedHtml).toString(); } - private StringBuilder processSanitization(boolean cleanData) throws UnsupportedEncodingException { + private StringBuilder processSanitization(boolean cleanMalformedHtml) throws UnsupportedEncodingException { OwaspThreadLocal threadLocalInstance = new OwaspThreadLocal(); threadLocalInstance.setVHost(vHost); OwaspHtmlSanitizer.zThreadLocal.set(threadLocalInstance); @@ -93,14 +93,14 @@ public void handle(final String x) { instantiatePolicy(); final Policy policy = POLICY_DEFINITION.apply(new StyleTagReceiver(renderer)); // run the html through the sanitizer - runSanitizer(html, policy, cleanData); + runSanitizer(html, policy, cleanMalformedHtml); // return the resulting HTML from the builder OwaspHtmlSanitizer.zThreadLocal.remove(); return htmlBuilder; } - private void runSanitizer(String str, Policy policy, boolean cleanData) throws UnsupportedEncodingException { - if (cleanData) { + private void runSanitizer(String str, Policy policy, boolean cleanMalformedHtml) throws UnsupportedEncodingException { + if (cleanMalformedHtml) { HtmlSanitizer.sanitize(cleanMalformedHtml(str, false), policy); } else { HtmlSanitizer.sanitize(str, policy);