Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Welsh powell coloring #395

Merged
merged 12 commits into from
Feb 2, 2024
Merged

Welsh powell coloring #395

merged 12 commits into from
Feb 2, 2024

Conversation

badumbatish
Copy link
Contributor

Hi there, I added documentation and removed some redundancy from my code from last pull request #391

@badumbatish
Copy link
Contributor Author

@ZigRazor

@ghost
Copy link

ghost commented Feb 2, 2024

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

Copy link

codecov bot commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d0ed302) 97.58% compared to head (fa70a6c) 97.58%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #395      +/-   ##
==========================================
- Coverage   97.58%   97.58%   -0.01%     
==========================================
  Files          87       87              
  Lines        9494     9492       -2     
==========================================
- Hits         9265     9263       -2     
  Misses        229      229              
Flag Coverage Δ
unittests 97.58% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@ZigRazor ZigRazor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well Done

@ZigRazor ZigRazor added documentation Improvements or additions to documentation enhancement New feature or request labels Feb 2, 2024
@ZigRazor ZigRazor linked an issue Feb 2, 2024 that may be closed by this pull request
@ZigRazor ZigRazor merged commit 1b31e63 into ZigRazor:master Feb 2, 2024
27 of 33 checks passed
@badumbatish badumbatish deleted the welsh_powell_coloring branch February 2, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce Welsh Powell Algorithm
2 participants